Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-committers-owner+archive@lists.postgresql.org>)
	id 1uAbFy-00HEzo-SJ
	for pgsql-committers@arkaria.postgresql.org; Thu, 01 May 2025 21:15:47 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-committers-owner+archive@lists.postgresql.org>)
	id 1uAbFw-005KzD-PB
	for pgsql-committers@arkaria.postgresql.org; Thu, 01 May 2025 21:15:45 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1uAbFw-005Kz5-IR
	for pgsql-committers@lists.postgresql.org; Thu, 01 May 2025 21:15:45 +0000
Received: from sss.pgh.pa.us ([68.162.161.243])
	by magus.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1uAbFv-000bJa-1p
	for pgsql-committers@lists.postgresql.org;
	Thu, 01 May 2025 21:15:45 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 541LFesM1658527;
	Thu, 1 May 2025 17:15:40 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter@eisentraut.org>
cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Make escaping functions retain trailing bytes of an
 invalid char
In-reply-to: <a9c837ad-d507-4607-94e4-c5743a8f49e0@eisentraut.org>
References: <E1tjPai-007Ji8-VF@gemulon.postgresql.org>
 <a9c837ad-d507-4607-94e4-c5743a8f49e0@eisentraut.org>
Comments: In-reply-to Peter Eisentraut <peter@eisentraut.org>
	message dated "Thu, 01 May 2025 23:04:27 +0200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1658525.1746134140.1@sss.pgh.pa.us>
Date: Thu, 01 May 2025 17:15:40 -0400
Message-ID: <1658526.1746134140@sss.pgh.pa.us>
List-Id: <pgsql-committers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-committers@lists.postgresql.org>
List-Owner: <mailto:pgsql-committers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-committers>
Archived-At: 
 <https://www.postgresql.org/message-id/1658526.1746134140%40sss.pgh.pa.us>
Precedence: bulk

Peter Eisentraut <peter@eisentraut.org> writes:
> On 15.02.25 22:20, Tom Lane wrote:
>> Make escaping functions retain trailing bytes of an invalid character.

> I think the backpatch of this to PG15 and older has erroneously dropped
> newlines at the end of some error messages.

Oh!  You're right, though I'd phrase it differently: I should have
*added* newlines when back-patching into those branches.  Will fix.

			regards, tom lane