Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cow7t-00057x-NJ for pgsql-hackers@arkaria.postgresql.org; Fri, 17 Mar 2017 17:57:21 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1cow7s-0001tB-VT for pgsql-hackers@arkaria.postgresql.org; Fri, 17 Mar 2017 17:57:21 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1cow7r-0001rr-Sq for pgsql-hackers@postgreSQL.org; Fri, 17 Mar 2017 17:57:19 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1cow7p-0005cN-7j for pgsql-hackers@postgreSQL.org; Fri, 17 Mar 2017 17:57:19 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id v2HHv7tR016610; Fri, 17 Mar 2017 13:57:07 -0400 From: Tom Lane To: Heikki Linnakangas cc: pgsql-hackers@postgreSQL.org Subject: Re: [COMMITTERS] pgsql: Fix and simplify check for whether we're running as Windows serv In-reply-to: References: Comments: In-reply-to Heikki Linnakangas message dated "Fri, 17 Mar 2017 09:18:54 -0000" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <16608.1489773427.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Fri, 17 Mar 2017 13:57:07 -0400 Message-ID: <16609.1489773427@sss.pgh.pa.us> X-Pg-Spam-Score: -1.9 (-) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org Heikki Linnakangas writes: > Fix and simplify check for whether we're running as Windows service. This seems to have broken narwhal: Creating library file: libpostgres.a ../../src/port/libpgport_srv.a(win32security_srv.o)(.text+0x109): In functi= on `pgwin32_is_admin': C:/msys/1.0/local/pgbuildfarm/buildroot/HEAD/pgsql.build/src/port/win32secu= rity.c:77: undefined reference to `CheckTokenMembership' ../../src/port/libpgport_srv.a(win32security_srv.o)(.text+0x127):C:/msys/1.= 0/local/pgbuildfarm/buildroot/HEAD/pgsql.build/src/port/win32security.c:77:= undefined reference to `CheckTokenMembership' ../../src/port/libpgport_srv.a(win32security_srv.o)(.text+0x264): In functi= on `pgwin32_is_service': C:/msys/1.0/local/pgbuildfarm/buildroot/HEAD/pgsql.build/src/port/win32secu= rity.c:138: undefined reference to `CheckTokenMembership' ../../src/port/libpgport_srv.a(win32security_srv.o)(.text+0x302):C:/msys/1.= 0/local/pgbuildfarm/buildroot/HEAD/pgsql.build/src/port/win32security.c:163= : undefined reference to `CheckTokenMembership' collect2: ld returned 1 exit status make[2]: *** [postgres] Error 1 regards, tom lane --=20 Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers