Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oEANx-0005gy-N1 for pgsql-hackers@arkaria.postgresql.org; Wed, 20 Jul 2022 14:09:09 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oEANw-0006d2-9M for pgsql-hackers@arkaria.postgresql.org; Wed, 20 Jul 2022 14:09:08 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oEANw-0006aD-0D for pgsql-hackers@lists.postgresql.org; Wed, 20 Jul 2022 14:09:08 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oEANt-0005mS-Vp for pgsql-hackers@lists.postgresql.org; Wed, 20 Jul 2022 14:09:07 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 26KE91MT1697007; Wed, 20 Jul 2022 10:09:01 -0400 From: Tom Lane To: Robert Haas cc: Alvaro Herrera , Andres Freund , Pavel Stehule , PostgreSQL Hackers Subject: Re: pgsql: Default to hidden visibility for extension libraries where possi In-reply-to: References: <20220720090247.kjqkzxh43vjaw45y@alvherre.pgsql> <1691356.1658324330@sss.pgh.pa.us> Comments: In-reply-to Robert Haas message dated "Wed, 20 Jul 2022 09:54:03 -0400" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1697005.1658326141.1@sss.pgh.pa.us> Date: Wed, 20 Jul 2022 10:09:01 -0400 Message-ID: <1697006.1658326141@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Robert Haas writes: > On Wed, Jul 20, 2022 at 9:39 AM Tom Lane wrote: >> ISTM that a comment pointing out that the functions marked PGDLLEXPORT >> are meant to be externally accessible should be sufficient. > The name PGDLLEXPORT is actually slightly misleading, now, because > there's no longer anything about it that is specific to DLLs. True, but the mess of changing it seems to outweigh any likely clarity gain. As long as there's adequate commentary about what it means, I'm okay with the existing naming. regards, tom lane