Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1f5tbk-0003ri-Ml
	for pgsql-hackers@arkaria.postgresql.org; Tue, 10 Apr 2018 13:46:48 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1f5tbj-0004k9-D5
	for pgsql-hackers@arkaria.postgresql.org; Tue, 10 Apr 2018 13:46:47 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1f5tbj-0004jt-5x
	for pgsql-hackers@lists.postgresql.org; Tue, 10 Apr 2018 13:46:47 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1f5tbb-0006pR-IH
	for pgsql-hackers@postgresql.org; Tue, 10 Apr 2018 13:46:46 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id w3ADkWI8017166;
	Tue, 10 Apr 2018 09:46:32 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Julien Rouhaud <rjuju123@gmail.com>
cc: Michael Paquier <michael@paquier.xyz>,
        Postgres hackers <pgsql-hackers@postgresql.org>
Subject: Re: pgsql: Merge catalog/pg_foo_fn.h headers back into pg_foo.h
 headers.
In-reply-to: 
 <CAOBaU_YH=g68opbbMk8is3jNwhoXGa8ckRSre1nx0Obe1C7i-Q@mail.gmail.com>
References: <E1f5FAB-0006LU-MB@gemulon.postgresql.org>
 <20180409010031.GA11599@paquier.xyz> <16609.1523243109@sss.pgh.pa.us>
 <20180409061354.GD1740@paquier.xyz> <6629.1523294509@sss.pgh.pa.us>
 <17755.1523306794@sss.pgh.pa.us>
 <CAOBaU_YH=g68opbbMk8is3jNwhoXGa8ckRSre1nx0Obe1C7i-Q@mail.gmail.com>
Comments: In-reply-to Julien Rouhaud <rjuju123@gmail.com>
	message dated "Tue, 10 Apr 2018 10:08:16 +0200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <17164.1523367992.1@sss.pgh.pa.us>
Date: Tue, 10 Apr 2018 09:46:32 -0400
Message-ID: <17165.1523367992@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

Julien Rouhaud <rjuju123@gmail.com> writes:
> Compilation of external extensions using PGXS appears to be broken
> since this commit:

Ouch, sorry.

> I think the best fix if to define NO_GENERATED_HEADERS in pgxs.mk,
> patch attached.

Hm.  I wonder if we don't also want NO_TEMP_INSTALL, like the doc/src/sgml
makefile.  I don't know whether "make check" could be useful in a PGXS
build, but certainly that recipe for making a temp install isn't gonna
work.

			regards, tom lane