Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mYZKA-0007R8-11 for pgsql-hackers@arkaria.postgresql.org; Thu, 07 Oct 2021 19:45:02 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mYZK8-0003ls-SM for pgsql-hackers@arkaria.postgresql.org; Thu, 07 Oct 2021 19:45:00 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mYZK8-0003j1-KX for pgsql-hackers@lists.postgresql.org; Thu, 07 Oct 2021 19:45:00 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mYZK2-0003fQ-Bs for pgsql-hackers@lists.postgresql.org; Thu, 07 Oct 2021 19:44:59 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 197JimRe173187; Thu, 7 Oct 2021 15:44:49 -0400 From: Tom Lane To: Daniel Gustafsson cc: pgsql-hackers@lists.postgresql.org, Craig Ringer , Noah Misch Subject: Re: pgsql: Adjust configure to insist on Perl version >= 5.8.3. In-reply-to: <12C3DA75-ACE1-486B-A432-9E23C68E7D34@yesql.se> References: <150C7533-8A64-4829-ABEA-50F0D49FC598@yesql.se> <161525.1633632402@sss.pgh.pa.us> <162421.1633633360@sss.pgh.pa.us> <12C3DA75-ACE1-486B-A432-9E23C68E7D34@yesql.se> Comments: In-reply-to Daniel Gustafsson message dated "Thu, 07 Oct 2021 21:18:19 +0200" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <173185.1633635888.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Thu, 07 Oct 2021 15:44:48 -0400 Message-ID: <173186.1633635888@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk [ cc'ing Craig and Noah, as author/committer of the existing text ] Daniel Gustafsson writes: > On 7 Oct 2021, at 21:02, Tom Lane wrote: >> BTW, looking at that a second time, I wonder if that advice is >> really of any use. > Yeah, I would have to agree. Reading that again I think what it perhaps= should > be saying is that 5.8.3 is the Perl API level that the testcode must con= form > to, but they should run with basically whichever recent Perl you have ha= ndy as > long as the required modules are installed. Not that we expect develope= rs to > run 5.8.3 when executing TAP tests. Yeah. I propose that what might be more useful than the existing last section of src/test/perl/README is something along the lines of: Avoid using any bleeding-edge Perl features. We have buildfarm animals running Perl versions as old as 5.8.3, so your tests will be expected to pass on that. Also, do not use any non-core Perl modules except IPC::Run. Or, if you must do so for a particular test, arrange to skip the test when the needed module isn't present. regards, tom lane