From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
cc: Michael Paquier <michael@paquier.xyz>,
        pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Rework option set of vacuumlo
In-reply-to: <12438.1535488750@sss.pgh.pa.us>
References: <E1fudM8-0000af-Lm@gemulon.postgresql.org>
 <12438.1535488750@sss.pgh.pa.us>
Comments: In-reply-to Tom Lane <tgl@sss.pgh.pa.us>
	message dated "Tue, 28 Aug 2018 16:39:10 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <17757.1535490505.1@sss.pgh.pa.us>
Date: Tue, 28 Aug 2018 17:08:25 -0400
Message-ID: <17758.1535490505@sss.pgh.pa.us>
Precedence: bulk

I wrote:
> Digging, this is because the "make check" processing isn't actually
> installing oid2name (resp. vacuumlo) into the temp installation tree :-(.
> 
> I don't think this is the fault of your tests, exactly --- there's
> something wrong in the existing make rules.  I'm not sure what though.
> EXTRA_INSTALL should be getting set, according to pgxs.mk:
> temp-install: EXTRA_INSTALL+=$(subdir)
> but it evidently isn't.

Oh!  The reason why not is that that line is inside "ifdef REGRESS",
and these subdirectories have no REGRESS tests.  So we should move
that out to where it will apply regardless of that.  Will fix.

			regards, tom lane