Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oAGut-0001rc-Da for pgsql-committers@arkaria.postgresql.org; Sat, 09 Jul 2022 20:19:03 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oAGts-0006ZS-Rs for pgsql-committers@arkaria.postgresql.org; Sat, 09 Jul 2022 20:18:00 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oAGtr-000680-M4 for pgsql-committers@lists.postgresql.org; Sat, 09 Jul 2022 20:18:00 +0000 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oAGtm-000565-SQ for pgsql-committers@lists.postgresql.org; Sat, 09 Jul 2022 20:17:56 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 9D64C3200077; Sat, 9 Jul 2022 16:17:52 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Sat, 09 Jul 2022 16:17:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1657397872; x= 1657484272; bh=mMY2QGAuZQoYlO0+jnsjcBfDM5MLQDcV46t4F2Y6SP4=; b=1 aXPya7Ok1weLBXh+czCOespLJneUjgnhHr/2837AHVvNtkLpvGWAY07rrOmz54qi J2g05vq1iuDiLGSGWW7A6fCn5+j3TEdRgyxFThXLHN5+HxUoBYwqpVvD42IIWFu/ lWiNFOt4z9ZlnCSTta5O1kkidJuhRigVrbEf9M9oG/ufVoCT2WDAzs1KJ5zGzHmC YMbBertbxKPdKZiW0M4Y678wP1CIvIgV3rID4uehvv0FAUAS64705m27uu3JIur4 EyPQOpMJgPegtza/VkYT0pI1QfIjhe5Egjy0MHOgq84+AkwiS/vgm7prBiqp0AHu tYu9k6gSBzirXo4f5Dwrw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudeiledgudehtdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhepkfffgggfuffvvehfhfgjtgfgse htjeertddtfeejnecuhfhrohhmpefrvghtvghrucfgihhsvghnthhrrghuthcuoehpvght vghrrdgvihhsvghnthhrrghuthesvghnthgvrhhprhhishgvuggsrdgtohhmqeenucggtf frrghtthgvrhhnpeehleffgeegudejteeihfelteduvdeifffhffdvjedvffegjeekudel udehudeifeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehpvghtvghrrdgvihhsvghnthhrrghuthesvghnthgvrhhprhhishgvuggsrdgtohhm X-ME-Proxy: Feedback-ID: i131946ab:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 9 Jul 2022 16:17:50 -0400 (EDT) Message-ID: <1784be53-3594-6b02-7a8a-8411e2c73e27@enterprisedb.com> Date: Sat, 9 Jul 2022 22:17:49 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: pgsql: Move a comment Content-Language: en-US To: Tom Lane Cc: pgsql-committers@lists.postgresql.org References: <3775998.1657379665@sss.pgh.pa.us> From: Peter Eisentraut In-Reply-To: <3775998.1657379665@sss.pgh.pa.us> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 09.07.22 17:14, Tom Lane wrote: > Peter Eisentraut writes: >> Move a comment from the to-be-deleted section of nodes.h to where it >> might still be useful. > > Hm. I'm kind of sad that we lost > > - /* > - * TAGS FOR RANDOM OTHER STUFF > - * > - * These are objects that aren't part of parse/plan/execute node tree > - * structures, but we give them NodeTags anyway for identification > - * purposes (usually because they are involved in APIs where we want to > - * pass multiple object types through the same pointer). > - */ > > Not quite sure where that info should be put now. Maybe nodes/README > could get another para that explains what types of objects get > treated as Nodes? Yeah, I looked at that comment, too, but it seemed that the particular node types were already adequately documented at their sites. But nodes/README seems like a good destination in general.