Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mYbG5-0003Pn-75 for pgsql-hackers@arkaria.postgresql.org; Thu, 07 Oct 2021 21:48:57 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mYbG3-0001BW-0u for pgsql-hackers@arkaria.postgresql.org; Thu, 07 Oct 2021 21:48:55 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mYbG2-0001BO-PE for pgsql-hackers@lists.postgresql.org; Thu, 07 Oct 2021 21:48:54 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mYbG0-0004fA-BH for pgsql-hackers@lists.postgresql.org; Thu, 07 Oct 2021 21:48:53 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 197LmjM4179778; Thu, 7 Oct 2021 17:48:45 -0400 From: Tom Lane To: Alvaro Herrera cc: Daniel Gustafsson , Postgres hackers , Craig Ringer , Noah Misch Subject: Re: pgsql: Adjust configure to insist on Perl version >= 5.8.3. In-reply-to: <202110072106.5vnpcxwxpmw6@alvherre.pgsql> References: <202110072106.5vnpcxwxpmw6@alvherre.pgsql> Comments: In-reply-to Alvaro Herrera message dated "Thu, 07 Oct 2021 18:06:10 -0300" MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----- =_aaaaaaaaaa0" Content-ID: <179675.1633643253.0@sss.pgh.pa.us> Date: Thu, 07 Oct 2021 17:48:45 -0400 Message-ID: <179777.1633643325@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk ------- =_aaaaaaaaaa0 Content-Type: text/plain; charset="us-ascii" Content-ID: <179675.1633643253.1@sss.pgh.pa.us> Alvaro Herrera writes: > On 2021-Oct-07, Tom Lane wrote: >> Hmm. I do see that Module::CoreList knows not only which modules >> are in core but when they were brought in, so that does seem like >> a really valuable reference to know about. Let's just say something >> like "You can consult Module::CoreList to find out whether and for >> long a module has been present in the Perl core." > WFM. Concretely, then, I propose the attached. regards, tom lane ------- =_aaaaaaaaaa0 Content-Type: text/x-diff; name="improve-test-perl-README.patch"; charset="us-ascii" Content-ID: <179675.1633643253.2@sss.pgh.pa.us> Content-Description: improve-test-perl-README.patch diff --git a/src/test/perl/README b/src/test/perl/README index bfc7cdcfa3..94b00096fb 100644 --- a/src/test/perl/README +++ b/src/test/perl/README @@ -70,20 +70,15 @@ perldoc for the test modules, e.g.: perldoc src/test/perl/PostgresNode.pm -Required Perl -------------- - -Tests must run on perl 5.8.3 and newer. perlbrew is a good way to obtain such -a Perl; see http://perlbrew.pl . - -Just install and - - perlbrew --force install 5.8.3 - perlbrew use 5.8.3 - perlbrew install-cpanm - cpanm install IPC::Run - -then re-run configure to ensure the correct Perl is used when running -tests. To verify that the right Perl was found: - - grep ^PERL= config.log +Portability +----------- + +Avoid using any bleeding-edge Perl features. We have buildfarm animals +running Perl versions as old as 5.8.3, so your tests will be expected +to pass on that. + +Also, do not use any non-core Perl modules except IPC::Run. Or, if you +must do so for a particular test, arrange to skip the test when the needed +module isn't present. If unsure, you can consult Module::CoreList to find +out whether a given module is part of the Perl core, and which module +versions shipped with which Perl releases. ------- =_aaaaaaaaaa0--