Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oWTqr-0004Gd-6m for pgsql-committers@arkaria.postgresql.org; Fri, 09 Sep 2022 02:34:41 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oWTqp-0002wJ-66 for pgsql-committers@arkaria.postgresql.org; Fri, 09 Sep 2022 02:34:39 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oWTqo-0002wA-VB for pgsql-committers@lists.postgresql.org; Fri, 09 Sep 2022 02:34:38 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oWTql-0002yC-Jc; Fri, 09 Sep 2022 02:34:38 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 2892YWwM001820; Thu, 8 Sep 2022 22:34:33 -0400 From: Tom Lane To: Amit Kapila cc: Masahiko Sawada , Amit Kapila , pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Raise a warning if there is a possibility of data from multiple In-reply-to: References: <3952373.1662645480@sss.pgh.pa.us> Comments: In-reply-to Amit Kapila message dated "Fri, 09 Sep 2022 06:33:04 +0530" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1818.1662690872.1@sss.pgh.pa.us> Date: Thu, 08 Sep 2022 22:34:32 -0400 Message-ID: <1819.1662690872@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Amit Kapila writes: > Fair enough. Do you mind being consistent in this regard for logical > replication-related code? As long as not too many individual changes are involved, sure. But consistency of this sort doesn't seem worth creating a lot of back-patching land mines, IMO. > BTW, is there a reason we prefer to write in > one or another way (with or without appending schema_name)? In places where we can trust the search_path to be just pg_catalog, there's no real strong reason to write a schema name, I think. regards, tom lane