Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e34YV-0006Q6-8q for pgsql-committers@arkaria.postgresql.org; Fri, 13 Oct 2017 18:19:31 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1e34YU-0005oI-Rv for pgsql-committers@arkaria.postgresql.org; Fri, 13 Oct 2017 18:19:30 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1e34YU-0005nf-9T for pgsql-committers@postgresql.org; Fri, 13 Oct 2017 18:19:30 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1e34YR-0004SZ-5w for pgsql-committers@postgresql.org; Fri, 13 Oct 2017 18:19:29 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id v9DIJMMN001821; Fri, 13 Oct 2017 14:19:23 -0400 From: Tom Lane To: Andres Freund cc: Noah Misch , pgsql-committers@postgresql.org Subject: Re: [HACKERS] pgsql: Improve performance of SendRowDescriptionMessage. In-reply-to: <20171013180106.ruju5qtn6xpw45us@alap3.anarazel.de> References: <307.1507819498@sss.pgh.pa.us> <20171012230844.ye4tnye2shysvqpk@alap3.anarazel.de> <20171013023536.GA492146@rfd.leadboat.com> <12267.1507862660@sss.pgh.pa.us> <20171013070247.GA505228@rfd.leadboat.com> <21773.1507908395@sss.pgh.pa.us> <530.1507916887@sss.pgh.pa.us> <20171013180106.ruju5qtn6xpw45us@alap3.anarazel.de> Comments: In-reply-to Andres Freund message dated "Fri, 13 Oct 2017 11:01:06 -0700" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1819.1507918762.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Fri, 13 Oct 2017 14:19:22 -0400 Message-ID: <1820.1507918762@sss.pgh.pa.us> List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-committers Precedence: bulk Sender: pgsql-committers-owner@postgresql.org Andres Freund writes: > A easiest way to do this would be to put something like > CPPFLAGS=3D"$CPPFLAGS -Dpg_restrict" into the existing > if test "$GCC" !=3D yes ; then > block in a/src/template/linux. But that'd probably result in "macro > redefined" warnings or somesuch. You mean src/template/aix, no? Agreed, that seems like a reasonable place to control it. But I'm pretty sure the above would flat out not work, the #define in pg_config.h would override it. > So it'd probably better to introduce a FORCE_DISABLE_RESTRICT=3Dyes, set > at the same place, that's then tested before running the relevant > configure check? +1. I think you don't actually have to skip the configure check, and there might be some value in letting it carry on normally (so that "restrict" is set properly). We'd just want it to affect what pg_restrict gets defined as. Something like if test "$ac_cv_c_restrict" =3D "no" -o "x$FORCE_DISABLE_RESTRICT" =3D "xye= s"; then pg_restrict=3D"" else pg_restrict=3D"$ac_cv_c_restrict" fi regards, tom lane --=20 Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers