From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
cc: Thomas Munro <thomas.munro@gmail.com>,
        =?iso-8859-1?Q?R=E9mi?= Zara <remi_zara@mac.com>,
        Michael Paquier <michael@paquier.xyz>,
        PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: pgsql: Add kqueue(2) support to the WaitEventSet API.
In-reply-to: <15886.1582572468@sss.pgh.pa.us>
References: <20200224191453.GA711@alvherre.pgsql>
 <15886.1582572468@sss.pgh.pa.us>
Comments: In-reply-to Tom Lane <tgl@sss.pgh.pa.us>
	message dated "Mon, 24 Feb 2020 14:27:48 -0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <18624.1582576221.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Mon, 24 Feb 2020 15:30:21 -0500
Message-ID: <18625.1582576221@sss.pgh.pa.us>
Precedence: bulk

I wrote:
> Alvaro Herrera <alvherre@2ndquadrant.com> writes:
>> As for the platform dependencies, I see two main options: make the hint
>> platform-specific (i.e have #ifdef branches per platform) or make it
>> even more generic, such as "file descriptor limits".

> I thought about platform-specific messages, but it's not clear to me
> whether our translation infrastructure will find messages that are
> inside #ifdefs ... anyone know?

Oh, but of course it does.  So let's do

        errdetail("There are too many open files on the local server."),
#ifndef WIN32
        errhint("Raise the server's max_files_per_process and/or \"ulimit =
-n\" limits.")
#else
        errhint("Raise the server's max_files_per_process setting.")
#endif

I don't think there's much point in telling Windows users about
_setmaxstdio() here.

			regards, tom lane