From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: pgsql-committers@postgresql.org
Subject: Re: pgsql: Add test for postmaster crash restarts.
In-reply-to: <20170919164718.66hcedq2rtlkntvf@alap3.anarazel.de>
References: <E1du6ZT-00043I-91@gemulon.postgresql.org>
 <5250.1505793335@sss.pgh.pa.us>
 <8818AEBD-57F7-420D-8348-CDB426020BFE@anarazel.de>
 <17084.1505837634@sss.pgh.pa.us>
 <20170919164718.66hcedq2rtlkntvf@alap3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Tue, 19 Sep 2017 09:47:18 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <18694.1505840008.1@sss.pgh.pa.us>
Date: Tue, 19 Sep 2017 12:53:28 -0400
Message-ID: <18695.1505840008@sss.pgh.pa.us>
Precedence: bulk
Sender: pgsql-committers-owner@postgresql.org

Andres Freund <andres@anarazel.de> writes:
> On 2017-09-19 12:13:54 -0400, Tom Lane wrote:
>> IOW, the "$monitor" instance of psql did not complete making its
>> connection until after the crash/restart cycle had occurred.

> That'd be easy enough to fix...

> Just something like

> $monitor_stdin .= q[
> SELECT $$am-i-up$$;
> ];
> $monitor->pump until $monitor_stdout =~ /am-i-up/;
> $monitor_stdout = '';

Hm, do we care whether the sleep call has started?  Maybe not.

>> I'd like to ask you to revert this test, at least pending making
>> it a whole lot more bulletproof.

> Hm. Ok. That seems like an overreaction to me - the failure rate isn't
> actualy that high so far.

It's not that it's high, it's that having to ask buildfarm owners to
manually unwedge their critters is not very cool.  Maybe prairiedog
will be the only one that gets stuck, but I kinda doubt it.

> I'm happy to add both timeouts and "earlier
> startup" of the $monitor, but I'd prefer to do so in-tree - I'd run the
> test through 100+ iterations locally, without any of this showing up.

Well, please fix it ASAP, if you don't want to take it out pending
the fixes.

			regards, tom lane


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers