Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lB3ss-0000QS-6b for pgsql-hackers@arkaria.postgresql.org; Sat, 13 Feb 2021 22:59:26 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lB3sr-0003UH-3B for pgsql-hackers@arkaria.postgresql.org; Sat, 13 Feb 2021 22:59:25 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lB3sq-0003UA-Rx for pgsql-hackers@lists.postgresql.org; Sat, 13 Feb 2021 22:59:24 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lB3so-0005Rm-Qx; Sat, 13 Feb 2021 22:59:23 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 11DMx9YG1870528; Sat, 13 Feb 2021 17:59:09 -0500 From: Tom Lane To: Alexander Korotkov cc: Thomas Munro , Heikki Linnakangas , Alexander Korotkov , PostgreSQL Hackers Subject: Re: Detecting pointer misalignment (was Re: pgsql: Implementation of subscripting for jsonb) In-reply-to: <1611008.1613170500@sss.pgh.pa.us> References: <37bb56a0-391d-759d-771b-9c1d8c15a84b@iki.fi> <3293925.1612163110@sss.pgh.pa.us> <475514.1612745257@sss.pgh.pa.us> <1557041.1613150383@sss.pgh.pa.us> <1611008.1613170500@sss.pgh.pa.us> Comments: In-reply-to Tom Lane message dated "Fri, 12 Feb 2021 17:55:00 -0500" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1870526.1613257149.1@sss.pgh.pa.us> Date: Sat, 13 Feb 2021 17:59:09 -0500 Message-ID: <1870527.1613257149@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk I wrote: > Alexander Korotkov writes: >> On Fri, Feb 12, 2021 at 8:19 PM Tom Lane wrote: >>> Once this does settle, should we consider back-patching so that it's >>> possible to run alignment checks in the back branches too? >> +1 > Let's make sure we have a clean set of builds and then do that. The buildfarm seems to be happy --- the active members that haven't reported in should be unaffected by this patch, either because their compiler versions are too old or because they're not x86 architecture. So I went ahead and back-patched, and have adjusted longfin to apply the -fsanitize switch in all branches. (I've checked that 9.6 passes check-world this way, but not the intermediate branches, so it's possible something will fail...) regards, tom lane