From: Tom Lane <tgl@sss.pgh.pa.us>
To: Jacob Champion <jacob.champion@enterprisedb.com>
cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: oauth: Add unit tests for multiplexer handling
In-reply-to: 
 <CAOYmi+=X_z3-aXzJcBdeRWRsUQLJLYF_uAZaUS0fq1cd17Qt-w@mail.gmail.com>
References: <E1ukPct-001PKA-0q@gemulon.postgresql.org>
 <CAOYmi+nCkoh3zB+GkZad44=FNskwUg6F1kmuxqQZzng7Zgj5tw@mail.gmail.com>
 <1871198.1754671345@sss.pgh.pa.us>
 <CAOYmi+nE8SbBkjudBSC55mspO45r1Ly+6pYtunRao0ua28hnRw@mail.gmail.com>
 <CAOYmi+=X_z3-aXzJcBdeRWRsUQLJLYF_uAZaUS0fq1cd17Qt-w@mail.gmail.com>
Comments: In-reply-to Jacob Champion <jacob.champion@enterprisedb.com>
	message dated "Fri, 08 Aug 2025 09:50:28 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1873916.1754672467.1@sss.pgh.pa.us>
Date: Fri, 08 Aug 2025 13:01:07 -0400
Message-ID: <1873917.1754672467@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1873917.1754672467%40sss.pgh.pa.us>
Precedence: bulk

Jacob Champion <jacob.champion@enterprisedb.com> writes:
> Before this commit, there was no t/ directory to get caught by the
> buildfarm. We've had to work around this in past, it looks like:
>> next if $testname =~ /ssl/ && !$using_ssl;

Yeah, that's a horrid kluge.  The makefiles themselves ought to
short-circuit building the test program.  I think the issue is that
we apply that short-circuit at the next makefile level up --- can
we do it in src/interfaces/libpq-oauth/Makefile itself?

			regards, tom lane