Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ukQrk-002GQu-So for pgsql-committers@arkaria.postgresql.org; Fri, 08 Aug 2025 17:26:52 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1ukQrj-00F5gZ-IV for pgsql-committers@arkaria.postgresql.org; Fri, 08 Aug 2025 17:26:51 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ukQrj-00F5gO-BU for pgsql-committers@lists.postgresql.org; Fri, 08 Aug 2025 17:26:51 +0000 Received: from sss.pgh.pa.us ([68.162.161.243]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1ukQrh-001Tj1-0G for pgsql-committers@lists.postgresql.org; Fri, 08 Aug 2025 17:26:51 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 578HQjD01876648; Fri, 8 Aug 2025 13:26:45 -0400 From: Tom Lane To: Jacob Champion cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: oauth: Add unit tests for multiplexer handling In-reply-to: References: <1871198.1754671345@sss.pgh.pa.us> <1873917.1754672467@sss.pgh.pa.us> Comments: In-reply-to Jacob Champion message dated "Fri, 08 Aug 2025 10:21:50 -0700" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1876646.1754674005.1@sss.pgh.pa.us> Date: Fri, 08 Aug 2025 13:26:45 -0400 Message-ID: <1876647.1754674005@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Jacob Champion writes: > So when I go for a followup next week... I could > 1) wrap just the installcheck and check targets in ifeq > 2) wrap the `all` target in addition to the above > 3) wrap everything after the Makefile.global inclusion > Any preferences? I think it'd be advisable to keep the "clean" target doing its thing. But I agree with disabling 'all', 'check', 'installcheck'. regards, tom lane