From: Tom Lane <tgl@sss.pgh.pa.us>
To: Masahiko Sawada <sawada.mshk@gmail.com>
cc: David Rowley <dgrowleyml@gmail.com>, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: pg_logicalinspect: Fix possible crash when passing a
 directory p
In-reply-to: 
 <CAD21AoDQJdQG3V3zvH7x9rEF97E8VD5OarArfpY+f4bEK5wNkw@mail.gmail.com>
References: <E1ts2ug-001xVQ-04@gemulon.postgresql.org>
 <CAApHDvqrhFfnetbcwgGkJ=z63T8HfQ_OyP=vX8BYiXyxFKt67w@mail.gmail.com>
 <CAD21AoDQJdQG3V3zvH7x9rEF97E8VD5OarArfpY+f4bEK5wNkw@mail.gmail.com>
Comments: In-reply-to Masahiko Sawada <sawada.mshk@gmail.com>
	message dated "Tue, 11 Mar 2025 21:56:14 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-ID: <1896563.1741756689.1@sss.pgh.pa.us>
Content-Transfer-Encoding: 8bit
Date: Wed, 12 Mar 2025 01:18:09 -0400
Message-ID: <1896564.1741756689@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1896564.1741756689%40sss.pgh.pa.us>
Precedence: bulk

Masahiko Sawada <sawada.mshk@gmail.com> writes:
> On Tue, Mar 11, 2025 at 7:08 PM David Rowley <dgrowleyml@gmail.com> wrote:
>> This introduces a new compiler warning for compilers that don't know
>> the ereport(ERROR) does not return.

> Thank you for the report. Can we generate the warning using some gcc's
> warning flags? I'd like to add a check to my personal pre-commit test.

I don't know of an easy way.  I experimented with doing this:

diff --git a/src/include/c.h b/src/include/c.h
index a14c6315162..467b1f58ae8 100644
--- a/src/include/c.h
+++ b/src/include/c.h
@@ -315,7 +315,7 @@
 #elif defined(_MSC_VER) && !defined(USE_ASSERT_CHECKING)
 #define pg_unreachable() __assume(0)
 #else
-#define pg_unreachable() abort()
+#define pg_unreachable() ((void) 0)
 #endif
 
 /*

which seems like it ought to be enough to provoke such warnings
(in assert-enabled builds).  I got upwards of sixty build warnings
this way, but the place David mentions was *not* among them.
So I'm confused.

			regards, tom lane