Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nmy1t-0004x5-Rj for pgsql-committers@arkaria.postgresql.org; Fri, 06 May 2022 13:29:57 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nmy1s-0002hB-DW for pgsql-committers@arkaria.postgresql.org; Fri, 06 May 2022 13:29:56 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nmy1s-0002h2-65 for pgsql-committers@lists.postgresql.org; Fri, 06 May 2022 13:29:56 +0000 Received: from out5-smtp.messagingengine.com ([66.111.4.29]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nmy1k-0001oL-Jb for pgsql-committers@lists.postgresql.org; Fri, 06 May 2022 13:29:54 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 4A6B85C00FF; Fri, 6 May 2022 09:29:47 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Fri, 06 May 2022 09:29:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:date:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1651843787; x=1651930187; bh=dWkAFzrLCq84k8TWbvGDB8OOi0fB N/SuHQ5SQLVT9Cs=; b=dsRiwwraVcITwY9rS8MKcuQW3+OxhzIKKdnAcIdJ9Rmf s5uuf+JTnhBfxG3eRxTarAoiHskHziBaRw+tfYL3glWAYo7LBaDdHEzMVHPtYLrJ Zhm8GLTL9i4Q4yzq1W7Zvrk/A4LoglCjuEnFhxof6rlD0+a/1X1W2qhxdZQWvD31 pLyWUI8y5WMjLvTUq7Ov9nvUbb1X9WVav2V5DL4J4zEZEWMLk2+0z9SVijKLhsIm Up9RPKDGnKrLvesNf+Cr49yTegkzdRkFOjVq6+zgVIra4XIU7qjhDue2feGxsG4w CCjqckgiX/MctWpdpaYLnkOGmrbGNJnOS41lLn+qTQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeefgdeifecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefkffggfgfuvfhfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpefrvghtvghr ucfgihhsvghnthhrrghuthcuoehpvghtvghrrdgvihhsvghnthhrrghuthesvghnthgvrh hprhhishgvuggsrdgtohhmqeenucggtffrrghtthgvrhhnpeefjeegheetuefhveevudel ueeftdejteeiffetvdduhfdtieefgfeutedtveeggfenucevlhhushhtvghrufhiiigvpe dtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehpvghtvghrrdgvihhsvghnthhrrghuthes vghnthgvrhhprhhishgvuggsrdgtohhm X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 6 May 2022 09:29:45 -0400 (EDT) Message-ID: <18b37361-b482-b9d8-f30d-6115cd5ce25c@enterprisedb.com> Date: Fri, 6 May 2022 15:29:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: pgsql: Backpatch addition of wait_for_log(), pump_until(). Content-Language: en-US To: Andres Freund , pgsql-committers@lists.postgresql.org References: From: Peter Eisentraut In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 03.05.22 03:11, Andres Freund wrote: > Backpatch addition of wait_for_log(), pump_until(). > > These were originally introduced in a2ab9c06ea1 and a2ab9c06ea1, as they are > needed by a about-to-be-backpatched test. I see this warning: Subroutine pump_until redefined at t/013_crash_restart.pl line 246. (There are a varying number of these warnings across the backbranches.) Also, the local definition has different arguments than the backpatched one. This should be double-checked.