From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Remove win32ver.rc from version_stamp.pl
In-reply-to: <50ecb345-4dc5-1f7d-64ca-7018195fcc8d@2ndquadrant.com>
References: <E1jBc1e-0006Yd-MY@gemulon.postgresql.org>
 <50ecb345-4dc5-1f7d-64ca-7018195fcc8d@2ndquadrant.com>
Comments: In-reply-to Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
	message dated "Tue, 10 Mar 2020 13:35:43 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <19047.1583851745.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Tue, 10 Mar 2020 10:49:05 -0400
Message-ID: <19048.1583851745@sss.pgh.pa.us>
Precedence: bulk

Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> This created some seemingly unrelated build farm failures.  I suspect =

> this must have something to do with the new shell code in configure

> +PG_MINORVERSION=3D`expr "$PACKAGE_VERSION" : '.*\.\([0-9][0-9]*\)'`
> +test -n "$PG_MINORVERSION" || PG_MINORVERSION=3D0

> ending up with some nonsense being assigned to PG_MINORVERSION, perhaps =

> due to a not-quite-mainstream Bourne shell being used.

Looking at the configure log on gharial, the only incorrect symbol
seems to be PG_VERSION_NUM:

#define PG_MAJORVERSION "13"
#define PG_MAJORVERSION_NUM 13
#define PG_MINORVERSION_NUM 0
#define PG_VERSION "13devel"
#define PG_VERSION_STR "PostgreSQL 13devel on ia64-hp-hpux11.31, compiled =
by gcc (GCC) 4.6.0, 64-bit"
#define PG_VERSION_NUM =


which squares with the compile error that's being thrown (it's pointing at
a macro that uses PG_VERSION_NUM).

I'd suggest reverting the change in how PG_VERSION_NUM is computed
in configure.in --- that was certainly not necessary to the patch,
and evidently you're falling foul of some weird behavior around
nesting double-quotes and backquotes.

			regards, tom lane