Message-ID: <190aad26-d04b-f2c6-c4a3-e184377f4c8c@dunslane.net>
Date: Mon, 13 Dec 2021 11:47:36 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.2.0
Subject: Re: pgsql: Check that we have a working tar before trying to use it
Content-Language: en-US
To: Michael Paquier <michael@paquier.xyz>
Cc: Andres Freund <andres@anarazel.de>, Tom Lane <tgl@sss.pgh.pa.us>,
 pgsql-committers@lists.postgresql.org
References: <3660797.1638983124@sss.pgh.pa.us>
 <b6782dc3-a7b0-ed56-175f-f8f54cb08d67@dunslane.net>
 <20211209021604.bv5tfr23ymh4u7x4@alap3.anarazel.de>
 <3707204.1639016334@sss.pgh.pa.us>
 <20211209024604.dpmudj4ax2hoi7cx@alap3.anarazel.de>
 <20211209030856.ibxewzpc5ph7ckkp@alap3.anarazel.de>
 <YbGYe483803il3X7@paquier.xyz>
 <20211209064928.7f5lp6hxvw2f2j6o@alap3.anarazel.de>
 <YbGr7ylYwE56l91B@paquier.xyz>
 <95787b2b-d483-0b5e-b24b-1986cff93596@dunslane.net>
 <Ybb/itFhY3FrsyzF@paquier.xyz>
From: Andrew Dunstan <andrew@dunslane.net>
In-Reply-To: <Ybb/itFhY3FrsyzF@paquier.xyz>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/190aad26-d04b-f2c6-c4a3-e184377f4c8c%40dunslane.net>
Precedence: bulk


On 12/13/21 03:08, Michael Paquier wrote:
> Also,
> the default values of LZ4, TAR and GZIP_PROGRAM had better be set
> *before* loading buildenv.pl, and not after it is loaded, no?  On
> HEAD, one has no way to unset any of those variables so it is not
> possible to skip things if an environment has in its PATH a funky
> command that TAP would refuse, like a tar command from MinGW or the
> git installation.


No. The code only sets them if they have not been previously set by
buildenv.pl or the calling environment. That's what "||=" means.


cheers


andrew


--
Andrew Dunstan
EDB: https://www.enterprisedb.com