Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o1Gdj-0002X4-IU for pgsql-committers@arkaria.postgresql.org; Wed, 15 Jun 2022 00:12:07 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1o1Gdh-0003AP-Cf for pgsql-committers@arkaria.postgresql.org; Wed, 15 Jun 2022 00:12:05 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o1Gdh-0003AG-62 for pgsql-committers@lists.postgresql.org; Wed, 15 Jun 2022 00:12:05 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o1Gde-0002gU-1H for pgsql-committers@lists.postgresql.org; Wed, 15 Jun 2022 00:12:04 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 25F0BxcH191586; Tue, 14 Jun 2022 20:11:59 -0400 From: Tom Lane To: Michael Paquier cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Force run of pg_upgrade in the build directory in its TAP test In-reply-to: References: <90595.1655227384@sss.pgh.pa.us> Comments: In-reply-to Michael Paquier message dated "Wed, 15 Jun 2022 09:00:00 +0900" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <191584.1655251919.1@sss.pgh.pa.us> Date: Tue, 14 Jun 2022 20:11:59 -0400 Message-ID: <191585.1655251919@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Michael Paquier writes: > On Tue, Jun 14, 2022 at 01:23:04PM -0400, Tom Lane wrote: >> I suppose it would be too user-unfriendly to generate those scripts >> underneath $PGDATA, so don't we need to put back the .gitignore >> entries? > delete_old_cluster.sh is generated within tmp_check/ in a non-VPATH > build: Sorry, I wasn't very clear: I'd tested pg_upgrade with a manual invocation, like "./pg_upgrade -d ...". That used to be OK and now it leaves junk around. I think it's worth keeping the .gitignore entries (and I guess the "make clean" rule step too) so that that approach still works without making a mess. regards, tom lane