Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1g5sau-0005La-P7 for pgsql-hackers@arkaria.postgresql.org; Fri, 28 Sep 2018 13:14:08 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1g5sat-000329-6N for pgsql-hackers@arkaria.postgresql.org; Fri, 28 Sep 2018 13:14:07 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1g5sas-000320-Vf for pgsql-hackers@lists.postgresql.org; Fri, 28 Sep 2018 13:14:07 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1g5saq-0005SO-1A for pgsql-hackers@postgresql.org; Fri, 28 Sep 2018 13:14:06 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id w8SDDuen019405; Fri, 28 Sep 2018 09:13:56 -0400 From: Tom Lane To: Christoph Berg cc: PostgreSQL Hackers Subject: Re: pgsql: Build src/port files as a library with -fPIC, and use that in li In-reply-to: <20180928115830.GC26142@msg.df7cb.de> References: <20180928115830.GC26142@msg.df7cb.de> Comments: In-reply-to Christoph Berg message dated "Fri, 28 Sep 2018 13:58:31 +0200" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <19403.1538140436.1@sss.pgh.pa.us> Date: Fri, 28 Sep 2018 09:13:56 -0400 Message-ID: <19404.1538140436@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Christoph Berg writes: > Re: Tom Lane 2018-09-27 >> Build src/port files as a library with -fPIC, and use that in libpq. > This made the "pqsignal" symbol disappear from libpq5.so: Oh, interesting. I'd seen an actual error on prairiedog, but apparently some other linkers just silently omit the export, if the symbol is in a .a file rather than .o. > Is this is a problem for libpq5 users? I proposed in https://www.postgresql.org/message-id/19581.1538077716@sss.pgh.pa.us that we should remove pqsignal, as well as pg_utf_mblen pg_encoding_to_char pg_char_to_encoding pg_valid_server_encoding pg_valid_server_encoding_id from libpq's exports, on the grounds that (a) nobody should be using those (they're undocumented as exports), and (b) anybody who is using them should get them from libpgport/libpgcommon instead. Thoughts? regards, tom lane