Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1io8vS-0003BO-Ih
	for pgsql-hackers@arkaria.postgresql.org; Sun, 05 Jan 2020 16:38:50 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1io8vR-0003fI-Ar
	for pgsql-hackers@arkaria.postgresql.org; Sun, 05 Jan 2020 16:38:49 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1io8vR-0003fB-1j
	for pgsql-hackers@lists.postgresql.org; Sun, 05 Jan 2020 16:38:49 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1io8vP-0001nE-JU
	for pgsql-hackers@postgresql.org; Sun, 05 Jan 2020 16:38:48 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id 005Gca8m019737;
	Sun, 5 Jan 2020 11:38:36 -0500
From: Tom Lane <tgl@sss.pgh.pa.us>
To: ilmari@ilmari.org (Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?=)
cc: Peter Geoghegan <pg@bowt.ie>, Robert Haas <robertmhaas@gmail.com>,
        Christoph Berg <myon@debian.org>,
        PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: pgsql: Add basic TAP tests for psql's tab-completion logic.
In-reply-to: <87k16610xk.fsf@wibble.ilmari.org>
References: <20200103170226.GB32629@msg.df7cb.de>
 <CA+TgmoZsPe_G1ssO6KVPqbMQHDEz=vHPQH1jxaSjpG_QxM7wUg@mail.gmail.com>
 <CAH2-WznPzfWHu8PQwv1Qjpf4wQVPaaWpoO5NunFz9zsYKB4uJA@mail.gmail.com>
 <22669.1578104202@sss.pgh.pa.us>
 <CAH2-WznyU3QxzRr12W_tJAzjwM9qd6bh_ZGx3Xupk3RqE1t72A@mail.gmail.com>
 <25298.1578106280@sss.pgh.pa.us>
 <CAH2-Wzkq4OELzn3yZvuqsPuso5JfSXdaD+yW=1VMz2YpXTBYxA@mail.gmail.com>
 <CAH2-Wzk3xfc53A0KZRe4Xu9TALRU=HSfSVZqx3jBuws08mG-ew@mail.gmail.com>
 <3055.1578115809@sss.pgh.pa.us>
 <CAH2-Wz=CtOruqXPd3naWXNiQ0WvLSFnCDYmSDWy0hKiLrppXDQ@mail.gmail.com>
 <8038.1578119995@sss.pgh.pa.us>
 <CAH2-Wz=f4B9+Ob-51-5z9G8a9LmztNpgo0YbKuTjxus3kFjpCg@mail.gmail.com>
 <9256.1578121229@sss.pgh.pa.us> <25739.1578161968@sss.pgh.pa.us>
 <22817.1578167447@sss.pgh.pa.us>
 <CAH2-Wz=4U_qKeLjN2FnLmSON8B5DgpMNXRdR4mLzgZjdpaMfUg@mail.gmail.com>
 <26857.1578183240@sss.pgh.pa.us>
 <CAH2-Wz=mJPd5cZwUdHGQ5sQsz6X58DivewER_WQ2+bx_ZU6yGw@mail.gmail.com>
 <912.1578189448@sss.pgh.pa.us> <CAH2-WzkicOOPb2AHa+PSeQ1-!
 N3qUV-0TKMX=EHVi55eH5Rtj9A@mail.gmail.com> <1888.1578190678@sss.pgh.pa.us>
 <87k16610xk.fsf@wibble.ilmari.org>
Comments: In-reply-to ilmari@ilmari.org (Dagfinn Ilmari
 =?utf-8?Q?Manns=C3=A5ker?=)
	message dated "Sun, 05 Jan 2020 13:35:03 +0000"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <19735.1578242316.1@sss.pgh.pa.us>
Date: Sun, 05 Jan 2020 11:38:36 -0500
Message-ID: <19736.1578242316@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

ilmari@ilmari.org (Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?=) writes:
> Here's one final style cleanup for the TAP test.

LGTM, pushed.

One minor note: you wanted to change the \DRD test to

+check_completion("\\DRD\t", qr/\\drds /, "complete \\DRD<tab> to \\drds");

but that doesn't work everywhere, unfortunately.  On my machine
what comes out is

# Actual output was "\\DRD\b\b\bdrds "
# Did not match "(?-xism:\\drds )"

			regards, tom lane