Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qroK3-005sdZ-83 for pgsql-committers@arkaria.postgresql.org; Sat, 14 Oct 2023 23:45:31 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1qroK0-009QJf-SC for pgsql-committers@arkaria.postgresql.org; Sat, 14 Oct 2023 23:45:29 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qroK0-009QJX-L9 for pgsql-committers@lists.postgresql.org; Sat, 14 Oct 2023 23:45:29 +0000 Received: from sss.pgh.pa.us ([68.162.161.243]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qroJy-000VzD-QG for pgsql-committers@lists.postgresql.org; Sat, 14 Oct 2023 23:45:28 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 39ENjLs21974778; Sat, 14 Oct 2023 19:45:21 -0400 From: Tom Lane To: Noah Misch cc: Peter Geoghegan , pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Dissociate btequalimage() from interval_ops, ending its deduplic In-reply-to: References: Comments: In-reply-to Noah Misch message dated "Sat, 14 Oct 2023 23:35:41 -0000" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1974776.1697327121.1@sss.pgh.pa.us> Date: Sat, 14 Oct 2023 19:45:21 -0400 Message-ID: <1974777.1697327121@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Noah Misch writes: > ... This fix makes interval_ops simply omit the support function, > like numeric_ops does. Back-pack to v13, where btequalimage() first > appeared. In back branches, for the benefit of old catalog content, > btequalimage() code will return false for type "interval". Going > forward, back-branch initdb will include the catalog change. Hmm, I'm not sure that that last is a good idea. The upshot of this (because of the opr_sanity.out change) is that "make installcheck" will fail against existing back-branch installations. That seems more likely to cause problems/confusion than the alternative of just depending on the code change. regards, tom lane