Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oqa8c-0002mv-SP for pgsql-committers@arkaria.postgresql.org; Thu, 03 Nov 2022 13:20:06 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oqa7d-0005IL-Pc for pgsql-committers@arkaria.postgresql.org; Thu, 03 Nov 2022 13:19:05 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oqa7d-0005Hv-IJ for pgsql-committers@lists.postgresql.org; Thu, 03 Nov 2022 13:19:05 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oqa7a-0006Xa-Sy for pgsql-committers@lists.postgresql.org; Thu, 03 Nov 2022 13:19:04 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 2A3DJ0Av1974930; Thu, 3 Nov 2022 09:19:01 -0400 From: Tom Lane To: John Naylor cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Straighten include order in guc-file.l In-reply-to: References: Comments: In-reply-to John Naylor message dated "Thu, 03 Nov 2022 13:03:04 +0700" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1974928.1667481540.1@sss.pgh.pa.us> Date: Thu, 03 Nov 2022 09:19:00 -0400 Message-ID: <1974929.1667481540@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk John Naylor writes: > flaviventris fails on the pg_resetwal test with "initdb: error: invalid > locale settings; check LANG and LC_* environment variables", and > idiacanthus fails to start the server in another tap test. But if this > commit were at fault, surely they would fail more spectacularly? Given the shortage of other failures, I'd write these off as noise ... unless they reproduce in future runs. But even then, it's very hard to blame it on this commit. regards, tom lane