From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
cc: Fabien COELHO <coelho@cri.ensmp.fr>, Teodor Sigaev <teodor@sigaev.ru>,
        pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Set random seed for pgbench.
In-reply-to: <20180401072208.GB2211@paquier.xyz>
References: <E1f0U1H-00005J-98@gemulon.postgresql.org>
 <32390.1522464534@sss.pgh.pa.us> <alpine.DEB.2.20.1803310828100.23311@lancre>
 <10686.1522514072@sss.pgh.pa.us> <alpine.DEB.2.20.1803311936450.23311@lancre>
 <20180401072208.GB2211@paquier.xyz>
Comments: In-reply-to Michael Paquier <michael@paquier.xyz>
	message dated "Sun, 01 Apr 2018 16:22:08 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <19793.1522599183.1@sss.pgh.pa.us>
Date: Sun, 01 Apr 2018 12:13:03 -0400
Message-ID: <19794.1522599183@sss.pgh.pa.us>
Precedence: bulk

Michael Paquier <michael@paquier.xyz> writes:
> I have not check in details this thread so I may be saying something
> stupid...  But if you are looking for a frontend implementation for
> strong randoms, please extract pg_frontend_random in fe-auth-scram.c and
> move it to its own file for example in src/common as a frontend-only
> file.  When working on SCRAM, I recall mentioning that but Heikki has
> kept the code in its current shape for simplicity.

I don't really see the point of doing more work than we've done there.
No modern platform should be without pg_strong_random, and if you've
actually had to use --disable-strong-random, it will not be astonishing
that you lose some functionality.

Also, while I personally do not see a use-case why somebody would need
cryptographically strong random seeds in pgbench, if somebody did need
that then they wouldn't thank us for silently falling back to a
not-strong generation method if the platform is misconfigured somehow.

			regards, tom lane