Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-committers-owner+archive@lists.postgresql.org>)
	id 1rxbSJ-00A2lH-Vp
	for pgsql-committers@arkaria.postgresql.org; Thu, 18 Apr 2024 23:46:15 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-committers-owner+archive@lists.postgresql.org>)
	id 1rxbSH-00ByKe-Mv
	for pgsql-committers@arkaria.postgresql.org; Thu, 18 Apr 2024 23:46:13 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1rxbSH-00ByKW-Fv
	for pgsql-committers@lists.postgresql.org; Thu, 18 Apr 2024 23:46:13 +0000
Received: from sss.pgh.pa.us ([68.162.161.243])
	by makus.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1rxbSC-003Wqn-Nm
	for pgsql-committers@lists.postgresql.org; Thu, 18 Apr 2024 23:46:12 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 43INk6di1979523;
	Thu, 18 Apr 2024 19:46:06 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew@dunslane.net>
cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix assorted bugs in ecpg's macro mechanism.
In-reply-to: <4cc4dc47-ca2b-4129-8784-db69b5f82777@dunslane.net>
References: <E1rwlil-002Ml4-3h@gemulon.postgresql.org>
 <4cc4dc47-ca2b-4129-8784-db69b5f82777@dunslane.net>
Comments: In-reply-to Andrew Dunstan <andrew@dunslane.net>
	message dated "Thu, 18 Apr 2024 18:55:22 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1979521.1713483966.1@sss.pgh.pa.us>
Date: Thu, 18 Apr 2024 19:46:06 -0400
Message-ID: <1979522.1713483966@sss.pgh.pa.us>
List-Id: <pgsql-committers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-committers@lists.postgresql.org>
List-Owner: <mailto:pgsql-committers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-committers>
Archived-At: 
 <https://www.postgresql.org/message-id/1979522.1713483966%40sss.pgh.pa.us>
Precedence: bulk

Andrew Dunstan <andrew@dunslane.net> writes:
> On 2024-04-16 Tu 12:31, Tom Lane wrote:
>> Fix assorted bugs in ecpg's macro mechanism.

> Buildfarm animals running the old MSVC build system don't like this.

Oh, duh, I'd already forgotten about that...

> It looks to me like we'll need an adjustment in 
> src/tools/msvc/ecpg_regression.proj to replicate the special rules 
> surrounding define.c and define_prelim.c. Not sure who has the requisite 
> knowledge to do that - I don't.

I will see if I can fix it.

			regards, tom lane