Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qrp0E-005unj-LK for pgsql-committers@arkaria.postgresql.org; Sun, 15 Oct 2023 00:29:06 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1qrozE-009azd-1x for pgsql-committers@arkaria.postgresql.org; Sun, 15 Oct 2023 00:28:04 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qrozD-009azU-R3 for pgsql-committers@lists.postgresql.org; Sun, 15 Oct 2023 00:28:04 +0000 Received: from sss.pgh.pa.us ([68.162.161.243]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qrozA-000iIS-HL for pgsql-committers@lists.postgresql.org; Sun, 15 Oct 2023 00:28:03 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 39F0RwEt1980112; Sat, 14 Oct 2023 20:27:58 -0400 From: Tom Lane To: Noah Misch cc: Peter Geoghegan , pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Dissociate btequalimage() from interval_ops, ending its deduplic In-reply-to: <20231015000358.2d@rfd.leadboat.com> References: <1974777.1697327121@sss.pgh.pa.us> <20231015000358.2d@rfd.leadboat.com> Comments: In-reply-to Noah Misch message dated "Sat, 14 Oct 2023 17:03:58 -0700" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1980110.1697329678.1@sss.pgh.pa.us> Date: Sat, 14 Oct 2023 20:27:58 -0400 Message-ID: <1980111.1697329678@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Noah Misch writes: > On Sat, Oct 14, 2023 at 07:45:21PM -0400, Tom Lane wrote: >> Hmm, I'm not sure that that last is a good idea. The upshot of this >> (because of the opr_sanity.out change) is that "make installcheck" >> will fail against existing back-branch installations. That seems >> more likely to cause problems/confusion than the alternative of just >> depending on the code change. > I'm way more worried about amcheck failing on all those indexes than I am > about someone who needs to tweak their installcheck rig. Well, that's indeed going to be a pain for affected people, but it doesn't seem like a reason to also break installcheck. regards, tom lane