From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
cc: pgsql-hackers@postgreSQL.org, Andrew Dunstan <andrew@dunslane.net>
Subject: Re: [COMMITTERS] pgsql: Use asynchronous connect API in
 libpqwalreceiver
In-reply-to: <34d98fbf-9195-04d2-b85a-634d6952ffdf@2ndquadrant.com>
References: <E1cjo1g-0000mr-ST@gemulon.postgresql.org>
 <19403.1488586564@sss.pgh.pa.us>
 <34d98fbf-9195-04d2-b85a-634d6952ffdf@2ndquadrant.com>
Comments: In-reply-to Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
	message dated "Fri, 03 Mar 2017 21:46:20 -0500"
Date: Fri, 03 Mar 2017 23:11:33 -0500
Message-ID: <19815.1488600693@sss.pgh.pa.us>
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> On 3/3/17 19:16, Tom Lane wrote:
>> Peter Eisentraut <peter_e@gmx.net> writes:
>>> Use asynchronous connect API in libpqwalreceiver

>> Buildfarm member bowerbird has been failing in the pg_rewind test since
>> this patch went in.  It looks like it's failing to complete connections
>> from the standby; which suggests that something platform-specific is
>> missing from this commit, but I dunno what.

> Hmm, I wonder how widely tested the async connection API is on Windows
> at all.  I only see bowerbird and jacana running bin-check on Windows.

Yeah, I was wondering if this is just exposing a pre-existing bug.
However, the "normal" path operates by repeatedly invoking PQconnectPoll
(cf. connectDBComplete) so it's not immediately obvious how such a bug
would've escaped detection.

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers