From: Tom Lane <tgl@sss.pgh.pa.us>
To: Christoph Berg <myon@debian.org>
cc: Andres Freund <andres@anarazel.de>, Amit Kapila <amit.kapila16@gmail.com>,
        PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: pgsql: Add basic TAP tests for psql's tab-completion logic.
In-reply-to: <20200106191303.GA3975@msg.df7cb.de>
References: <E1in6ft-0004zR-6l@gemulon.postgresql.org>
 <20200103110128.GA28967@msg.df7cb.de> <13708.1578059577@sss.pgh.pa.us>
 <25771.1578249042@sss.pgh.pa.us> <20200106105608.GB18560@msg.df7cb.de>
 <3764.1578323719@sss.pgh.pa.us> <20200106191303.GA3975@msg.df7cb.de>
Comments: In-reply-to Christoph Berg <myon@debian.org>
	message dated "Mon, 06 Jan 2020 20:13:03 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <19972.1578351988.1@sss.pgh.pa.us>
Date: Mon, 06 Jan 2020 18:06:28 -0500
Message-ID: <19973.1578351988@sss.pgh.pa.us>
Precedence: bulk

Christoph Berg <myon@debian.org> writes:
> Re: Tom Lane 2020-01-06 <3764.1578323719@sss.pgh.pa.us>
>>> Does not work on Ubuntu bionic, xenial. (Others not tested.)

>> Hmm ... do we care?  The test output seems to show that xenial's
>> 3.1-20150325-1ubuntu2 libedit is completely broken.  Maybe there's
>> a way to work around that, but it's not clear to me that that'd
>> be a useful expenditure of time.  You're not really going to be
>> building PG13 for that release are you?

> xenial (16.04) is a LTS release with support until 2021-04, and the
> current plan was to support it. I now realize that's semi-close to the
> 13 release date, but so far we have tried to really support all
> PG-Distro combinations.

I installed libedit_3.1-20150325.orig.tar.gz from source here, and it
passes our current regression test and seems to behave just fine in
light manual testing.  (I did not apply any of the Debian-specific
patches at [1], but they don't look like they'd explain much.)
So I'm a bit at a loss as to what's going wrong for you.  Is the test
environment for Xenial the same as for the other branches?

			regards, tom lane

[1] https://launchpad.net/ubuntu/+source/libedit/3.1-20150325-1ubuntu2