Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cGbZx-0001sX-OA for pgsql-committers@arkaria.postgresql.org; Tue, 13 Dec 2016 01:08:25 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1cGbZx-0007xp-B8 for pgsql-committers@arkaria.postgresql.org; Tue, 13 Dec 2016 01:08:25 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1cGbZj-0007TM-GT for pgsql-committers@postgresql.org; Tue, 13 Dec 2016 01:08:11 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1cGbZg-0004yy-U3 for pgsql-committers@postgresql.org; Tue, 13 Dec 2016 01:08:10 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id uBD181L4019998; Mon, 12 Dec 2016 20:08:01 -0500 From: Tom Lane To: Andres Freund cc: Petr Jelinek , Peter Eisentraut , pgsql-committers@postgresql.org Subject: Re: pgsql: Add support for temporary replication slots In-reply-to: <20161213010059.dn64rrb3u7zxnnwk@alap3.anarazel.de> References: <27274.1481557380@sss.pgh.pa.us> <27833.1481558144@sss.pgh.pa.us> <62935e6f-4f1b-c433-e0fa-7f936a38b3e5@2ndquadrant.com> <22907.1481571177@sss.pgh.pa.us> <15713.1481585953@sss.pgh.pa.us> <314cae39-2e7d-f5a3-d226-cfb80cf80481@2ndquadrant.com> <18684.1481589637@sss.pgh.pa.us> <48b2c017-695d-b5ac-2ff4-89b939b3e8f9@2ndquadrant.com> <20161213004903.iito2pefdrrjgny5@alap3.anarazel.de> <6886c56a-f6c8-3c44-53a1-dae6c24afb76@2ndquadrant.com> <20161213010059.dn64rrb3u7zxnnwk@alap3.anarazel.de> Comments: In-reply-to Andres Freund message dated "Mon, 12 Dec 2016 17:00:59 -0800" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <19996.1481591281.1@sss.pgh.pa.us> Date: Mon, 12 Dec 2016 20:08:01 -0500 Message-ID: <19997.1481591281@sss.pgh.pa.us> X-Pg-Spam-Score: -5.0 (-----) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-committers Precedence: bulk Sender: pgsql-committers-owner@postgresql.org Andres Freund writes: > On 2016-12-13 01:57:01 +0100, Petr Jelinek wrote: >> I mentioned that as possible solution upthread, I am only worried that >> the failure scenario is basically infinite loop. > I don't see the problem with that. If you're really concerned you can > set a statement timeout. I don't think "change the test" is the right response here. I think the problem is that we're disconnecting from the slot at the wrong step of backend shutdown, and that we need to fix that before it bites us on some more painful parts of our anatomies. You can't just throw darts at the code when deciding where to do things, and proc.c is NOT the place that should be concerned with replication slots. regards, tom lane -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers