Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
From: Daniel Gustafsson <daniel@yesql.se>
Mime-Version: 1.0 (1.0)
Subject: Re: pgsql: Revert online data checksum transitions
Date: Wed, 16 Sep 2026 13:08:12 +0200
Message-Id: <1EEAFCFB-15DB-4EC1-BD49-964C799A01B2@yesql.se>
References: 
 <CAHGQGwH-wHTq4xd2dedEj0niDHkezcCT_OLmMpGp9NEHW4Dvkw@mail.gmail.com>
Cc: Daniel Gustafsson <dgustafsson@postgresql.org>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
In-Reply-To: 
 <CAHGQGwH-wHTq4xd2dedEj0niDHkezcCT_OLmMpGp9NEHW4Dvkw@mail.gmail.com>
To: Masao Fujii <masao.fujii@gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/1EEAFCFB-15DB-4EC1-BD49-964C799A01B2%40yesql.se>
Precedence: bulk

> On 16 Sep 2026, at 13:01, Fujii Masao <masao.fujii@gmail.com> wrote:
>=20
> =EF=BB=BFOn Wed, Sep 16, 2026 at 6:06=E2=80=AFPM Daniel Gustafsson
> <dgustafsson@postgresql.org> wrote:
>>=20
>> Revert online data checksum transitions
>=20
> It's unfortunate that this feature had to be reverted...
> Anyway, thanks for all your hard work on it!!
>=20
>=20
> After the revert, the buildfarm member longfin reported the test failure [=
1],
> which seems to have been caused by the revert.
>=20
> According to longfin's server log, the test triggers the following
> assertion failure:
>=20
>    TRAP: failed Assert("(data - start) =3D=3D data_size"), File:
> "heaptuple.c", Line: 442, PID: 78459
>    ...
>    2026-09-16 06:03:57.172 EDT [77693:4] LOG:  client backend (PID
> 78459) was terminated by signal 6: Abort trap: 6
>    2026-09-16 06:03:57.172 EDT [77693:5] DETAIL:  Failed process was
> running: SELECT count(*) > 0 AS ok FROM pg_control_checkpoint();
>=20
> After the revert, pg_control_checkpoint() now returns 19 columns, but its
> pg_proc.dat entry still declares 20 output columns, including
> data_page_checksum_version. This seems to trigger the assertion failure
> in heap_form_tuple().
>=20
> We should remove data_page_checksum_version from the pg_control_checkpoint=

> entry in pg_proc.dat and reduce proargmodes from 20 output columns to 19?

Ugh, I thought I had tested everything but clearly missed this one. Will fix=
 immediately when back from lunch.

./daniel=