Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1hJsMU-00009d-RB
	for pgsql-hackers@arkaria.postgresql.org; Fri, 26 Apr 2019 04:21:22 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1hJsMS-0004uP-GW
	for pgsql-hackers@arkaria.postgresql.org; Fri, 26 Apr 2019 04:21:20 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <Langote_Amit_f8@lab.ntt.co.jp>)
	id 1hJsMS-0004sO-2h; Fri, 26 Apr 2019 04:21:20 +0000
Received: from tama500.ecl.ntt.co.jp ([129.60.39.148])
	by makus.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <Langote_Amit_f8@lab.ntt.co.jp>)
	id 1hJsMK-0000Wu-5n; Fri, 26 Apr 2019 04:21:18 +0000
Received: from vc2.ecl.ntt.co.jp (vc2.ecl.ntt.co.jp [129.60.86.154])
	by tama500.ecl.ntt.co.jp (8.13.8/8.13.8) with ESMTP id x3Q4KhkC029151;
	Fri, 26 Apr 2019 13:20:43 +0900
Received: from vc2.ecl.ntt.co.jp (localhost [127.0.0.1])
	by vc2.ecl.ntt.co.jp (Postfix) with ESMTP id 8E37E638A74;
	Fri, 26 Apr 2019 13:20:43 +0900 (JST)
Received: from jcms-pop21.ecl.ntt.co.jp (jcms-pop21.ecl.ntt.co.jp
 [129.60.87.134])
	by vc2.ecl.ntt.co.jp (Postfix) with ESMTP id 823E1638A49;
	Fri, 26 Apr 2019 13:20:43 +0900 (JST)
Received: from [127.0.0.1] (unknown [129.60.241.61])
	by jcms-pop21.ecl.ntt.co.jp (Postfix) with ESMTPSA id 7A8194001F0;
	Fri, 26 Apr 2019 13:20:43 +0900 (JST)
Subject: Re: pgsql: Allow insert and update tuple routing and COPY for foreign
 table
References: <E1f4aif-0004qo-A6@gemulon.postgresql.org>
 <ed0b7471dce91169d871347cf003d8094ab96895.camel@cybertec.at>
 <5CBDB770.2060602@lab.ntt.co.jp>
 <b459d1b1b4eb8c0d538a2c5b70e131af3c391954.camel@cybertec.at>
 <5CC04E72.90405@lab.ntt.co.jp>
 <bf36a0288e8f31b4f2f40952e225bf892dc1ffc5.camel@cybertec.at>
 <5CC1B358.5090205@lab.ntt.co.jp>
From: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
Message-ID: <1cc7b8be-d201-8bad-5d98-350faccf095c@lab.ntt.co.jp>
Date: Fri, 26 Apr 2019 13:20:31 +0900
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <5CC1B358.5090205@lab.ntt.co.jp>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
X-CC-Mail-RelayStamp: 1
To: Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>,
        Laurenz Albe <laurenz.albe@cybertec.at>
Cc: Robert Haas <rhaas@postgresql.org>, pgsql-committers@lists.postgresql.org,
        pgsql-hackers@lists.postgresql.org
X-TM-AS-MML: disable
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

Fujita-san,

On 2019/04/25 22:17, Etsuro Fujita wrote:
> (2019/04/24 22:04), Laurenz Albe wrote:
>>    Before PostgreSQL v11, a foreign data wrapper could be certain that
>>    BeginForeignModify is always called before ExecForeignInsert.
>>    This is no longer true.
> 
> OK, how about something like the attached?  I reworded this a bit, though.

Thanks for the patch.

+     Note that this function is also called when inserting routed tuples into
+     a foreign-table partition or executing <command>COPY FROM</command> on
+     a foreign table, in which case it is called in a different way than it
+     is in the <command>INSERT</command> case.

Maybe minor, but should the last part of this sentence read as:

...in which case it is called in a different way than it is in the case
<command>INSERT</command> is operating directly on the foreign table.

?

Thanks,
Amit