Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.92) (envelope-from ) id 1j9uf8-0002aC-9N for pgsql-committers@arkaria.postgresql.org; Thu, 05 Mar 2020 17:51:58 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1j9uf7-0000Iv-3o for pgsql-committers@arkaria.postgresql.org; Thu, 05 Mar 2020 17:51:57 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1j9uf6-0000Io-TD for pgsql-committers@lists.postgresql.org; Thu, 05 Mar 2020 17:51:56 +0000 Received: from mail.thelabyrinth.net ([45.56.70.56]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j9uf3-0002VH-TZ for pgsql-committers@lists.postgresql.org; Thu, 05 Mar 2020 17:51:56 +0000 Received: from Davids-MacBook-Pro.local (c-73-39-102-148.hsd1.va.comcast.net [73.39.102.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: dsteele) by mail.thelabyrinth.net (Postfix) with ESMTPSA id 82A315465C; Thu, 5 Mar 2020 17:51:51 +0000 (UTC) Subject: Re: pgsql: Avoid -Wconversion warnings when using checksum_impl.h To: Michael Paquier , pgsql-committers@lists.postgresql.org References: From: David Steele Message-ID: <1cf30561-7dad-dc6e-9fc3-5c456948cfeb@pgmasters.net> Date: Thu, 5 Mar 2020 12:51:50 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Hi Michael, On 3/5/20 12:13 AM, Michael Paquier wrote: > Avoid -Wconversion warnings when using checksum_impl.h > > This does not matter much when compiling Postgres proper as many > warnings exist when enabling this compilation flag, but it can be > annoying for external modules willing to use both. Looks like you changed 65535 -> 65536 before commit. I checked the original patch and it has 65535. Bit of a bummer that this passed make check-world, but the pgBackRest tests definitely did not like it. Thanks, -- -David david@pgmasters.net