Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-committers-owner+archive@lists.postgresql.org>)
	id 1ruSV1-005Xmu-Fz
	for pgsql-committers@arkaria.postgresql.org; Wed, 10 Apr 2024 07:36:04 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-committers-owner+archive@lists.postgresql.org>)
	id 1ruSV0-00GnoO-Gm
	for pgsql-committers@arkaria.postgresql.org; Wed, 10 Apr 2024 07:36:02 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <peter@eisentraut.org>)
	id 1ruSV0-00GnoG-9Z
	for pgsql-committers@lists.postgresql.org; Wed, 10 Apr 2024 07:36:02 +0000
Received: from wfhigh6-smtp.messagingengine.com ([64.147.123.157])
	by magus.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <peter@eisentraut.org>)
	id 1ruSUx-0009u0-Q3
	for pgsql-committers@lists.postgresql.org; Wed, 10 Apr 2024 07:36:01 +0000
Received: from compute4.internal (compute4.nyi.internal [10.202.2.44])
	by mailfhigh.west.internal (Postfix) with ESMTP id 5B1D7180013B;
	Wed, 10 Apr 2024 03:35:56 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
  by compute4.internal (MEProxy); Wed, 10 Apr 2024 03:35:56 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eisentraut.org;
	 h=cc:cc:content-transfer-encoding:content-type:content-type
	:date:date:from:from:in-reply-to:in-reply-to:message-id
	:mime-version:references:reply-to:subject:subject:to:to; s=fm1;
	 t=1712734555; x=1712820955; bh=qlbpJB8sbktbVmBSP24O0WPvB0BT4CFX
	qxxW5YF2g7k=; b=crvTPAq2j2H0baCfDTLqe3WpiVc1If3ep4x2KgqpUpRBaCw2
	c5qQwmYz3pC0kTagm65ywvavAjKoMOaoHUP4RhJRL22ER5LmrLFoBDLX66AOnalh
	8bDhkcniXR2iQp6rWYrSnyEP9KgCq0WRr/LeTMoD+w+B5rUmntI5zfC18CQ2zqlT
	/1jr6Na/ROkD1u/56lmn7TQ8Y24kLaa3eyxvO3ayao1qSOf5DZu9NxTjvFwU89zO
	eCThY/DJAnuooZWeETW6Bftrg3Gt2gqf0IsdKqwGiYP9BARgMYRPPj2+x2GStURa
	dcaz9KShL+Q36jSmMbY1WqoBAhPHkJmFkixihA==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:cc:content-transfer-encoding
	:content-type:content-type:date:date:feedback-id:feedback-id
	:from:from:in-reply-to:in-reply-to:message-id:mime-version
	:references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy
	:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1712734555; x=
	1712820955; bh=qlbpJB8sbktbVmBSP24O0WPvB0BT4CFXqxxW5YF2g7k=; b=s
	BxEplQjgsBEXSkURc8tZ1rX67PD+m9joZUxF7FaHiEfCCTjyqS05E5mN1ikOkU3l
	XLmZkrr6+ZRJPpVswUrd6SnxnFAQG82x3ozAiWXR7f8g6NzhbH9X4pXBPqCKyGJv
	CsdcgprvZIWZ+GknUSPco3olcpy3VIeSQLAEWAmLRXWegE/F3A3ePi5Fs3MCZ9mu
	4WlZm1wTX7SJ8+oCNQxTTPq92PmPIA0Mnpf5axLotpUzw3C9WfX6kh31eepXVEx/
	tZZOaF5ac3CiFUafla62awBQmF5+yTRY3rhbCqgtwyyatO8deoJxffWayEPs0nXA
	GI8aF5jbZFsOiTvNCyyOg==
X-ME-Sender: <xms:W0EWZqcssljdkCsaRqI_fr5YFgf0jYKHvQoH-2Xfas-HUjg7nUiHfQ>
    <xme:W0EWZkMp5RvPVpgQ5RVH-bYh5Ru-YAT8a9yhsbgRg0dE4tdIaxhgLn3GixyIB5dV1
    Eu7tQD-ZoKx8rDB9w>
X-ME-Received: 
 <xmr:W0EWZrgbyd5s4yyBIEt98_E9xL1jaq7rVWmH-dqt6UtSXNvPoMarsSmYFi5uSze48fRKXFC63KCshWMOYDN-R8e6R4apTz_Rpw>
X-ME-Proxy-Cause: 
 gggruggvucftvghtrhhoucdtuddrgedvledrudehhedguddukecutefuodetggdotefrod
    ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh
    necuuegrihhlohhuthemuceftddtnecunecujfgurhepkfffgggfuffvvehfhfgjtgfgse
    htjeertddtvdejnecuhfhrohhmpefrvghtvghrucfgihhsvghnthhrrghuthcuoehpvght
    vghrsegvihhsvghnthhrrghuthdrohhrgheqnecuggftrfgrthhtvghrnhepgfejtdfhke
    eftdeugfeileehteeljeeghfeuledthfeutedvffdukeefjefhgeehnecuvehluhhsthgv
    rhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepphgvthgvrhesvghishgvnh
    htrhgruhhtrdhorhhg
X-ME-Proxy: <xmx:W0EWZn-JC-06DqPW-WZx0u-ZmVjNaAfTZlORmFripPeO7P3DhZjsVw>
    <xmx:W0EWZmtpyWotSZFSgZ_cTYkovHUai8qs3M1tdc7OnGAZRQ8GdnXFxw>
    <xmx:W0EWZuGgAuYry6HoOBnsYN3tKzWwJ5UlzdEoFRQXzxo4jAEomERbgg>
    <xmx:W0EWZlM3sisuJBfQ8Tzx9lsKLqjE-_WdPRR3XaMOOK1atSOydZvlJw>
    <xmx:W0EWZv4YskpqX4Se8CHItGfH0RU4HU-FuLdoHQpJUwd7xd6XkIHjrP8z>
Feedback-ID: ie0a040ee:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed,
 10 Apr 2024 03:35:55 -0400 (EDT)
Message-ID: <1e1a098e-b9af-4c95-8dea-7338d1c4e46d@eisentraut.org>
Date: Wed, 10 Apr 2024 09:35:54 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: pgsql: Introduce a bump memory allocator
To: David Rowley <dgrowleyml@gmail.com>
Cc: pgsql-committers@lists.postgresql.org
References: <E1rtRFE-000y8T-SU@gemulon.postgresql.org>
 <5f724fb2-96e1-4f36-b65b-47b337ad432e@eisentraut.org>
 <CAApHDvpKf+6vFoDe1HmqVMkv=cgY1WHP-Kw6=BPaXxGptBP=3g@mail.gmail.com>
Content-Language: en-US
From: Peter Eisentraut <peter@eisentraut.org>
In-Reply-To: 
 <CAApHDvpKf+6vFoDe1HmqVMkv=cgY1WHP-Kw6=BPaXxGptBP=3g@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: <pgsql-committers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-committers@lists.postgresql.org>
List-Owner: <mailto:pgsql-committers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-committers>
Archived-At: 
 <https://www.postgresql.org/message-id/1e1a098e-b9af-4c95-8dea-7338d1c4e46d%40eisentraut.org>
Precedence: bulk

On 10.04.24 01:11, David Rowley wrote:
> On Wed, 10 Apr 2024 at 00:05, Peter Eisentraut <peter@eisentraut.org> wrote:
>> This patch introduces in bump.c the macro BumpBlockIsValid(), but it's
>> not used anywhere.  Can we remove it?
> 
> I've just pushed a patch to remove it.
> 
> Was that spotted by eagle eyes or tooling?

I used gcc -Wunused-macros.  This is somewhat noisy, but occasionally 
useful to find leftover stuff.