Subject: Re: pgsql: Add a regression test for allow_system_table_mods
To: Tom Lane <tgl@sss.pgh.pa.us>
References: <E1iacW7-0003h6-6U@gemulon.postgresql.org>
 <13656.1575041267@sss.pgh.pa.us>
 <315cfd3b-9d04-0ea4-76d8-1507c8bd9bb7@2ndquadrant.com>
 <15399.1575043746@sss.pgh.pa.us>
Cc: pgsql-committers@lists.postgresql.org
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Organization: 2ndQuadrant
Message-ID: <1e7bb9a1-1104-907d-da62-857408d271ef@2ndquadrant.com>
Date: Mon, 2 Dec 2019 11:09:49 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0)
 Gecko/20100101 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <15399.1575043746@sss.pgh.pa.us>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2019-11-29 17:09, Tom Lane wrote:
>>> +WARNING:  tablespaces created by regression test cases should have names starting with "regress_"
> I agree that this is somewhat pointless in the case of an "unsafe" test.
> But using a different name isn't going to invalidate the test case,
> so there's not really a reason to not follow the convention.  And
> trying to have an exception for unsafe_tests seems like a lot more
> trouble than it'd be worth.

The test case is specifically testing tablespace names starting with "pg_":

     -- reserved tablespace name
     CREATE TABLESPACE pg_foo LOCATION '/no/such/location';
     ERROR:  unacceptable tablespace name "pg_foo"
     DETAIL:  The prefix "pg_" is reserved for system tablespaces.

So using a name starting with "regress_" instead isn't going to help.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services