From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
cc: pgsql-committers@lists.postgresql.org,
        Andrew Dunstan <andrew@dunslane.net>
Subject: Re: pgsql: Emit parameter values during query bind/execute errors
In-reply-to: <20191212164720.GA27169@alvherre.pgsql>
References: <20191212164720.GA27169@alvherre.pgsql>
Comments: In-reply-to Alvaro Herrera <alvherre@2ndquadrant.com>
	message dated "Thu, 12 Dec 2019 13:47:20 -0300"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2000.1576172486.1@sss.pgh.pa.us>
Date: Thu, 12 Dec 2019 12:41:26 -0500
Message-ID: <2001.1576172486@sss.pgh.pa.us>
Precedence: bulk

Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> Hmm, the affected ones (jacana and fairywren only AFAICS) seem to be
> gcc-based, which presumably work differently than the msvc-based in how
> newlines are interpreted in the test script.  I pushed an attempted
> blind fix.

> I *hope* that those two are not the only Windows ones running the
> pgbench tap test!

[ scrapes buildfarm results... ]  The Windows critters that are
running that test seem to be

   name    | operating_system |   compiler    
-----------+------------------+---------------
 bowerbird | Windows          | Visual Studio
 drongo    | Windows          | Visual Studio
 fairywren | Windows / Msys   | gcc
 jacana    | Windows          | gcc

So yeah, the MSVC ones were happy with the test as you had it.
Interesting ... it's not obvious why that would have anything
to do with the behavior of a Perl regexp.  Maybe they are using
a different Perl version?

			regards, tom lane