Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1msYKY-0000bc-9w for pgsql-committers@arkaria.postgresql.org; Wed, 01 Dec 2021 22:44:02 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1msYKW-0001qE-QJ for pgsql-committers@arkaria.postgresql.org; Wed, 01 Dec 2021 22:44:00 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1msYKW-0001q5-JM for pgsql-committers@lists.postgresql.org; Wed, 01 Dec 2021 22:44:00 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1msYKU-00069G-EZ for pgsql-committers@lists.postgresql.org; Wed, 01 Dec 2021 22:43:59 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 1B1Mhvqo2001387; Wed, 1 Dec 2021 17:43:57 -0500 From: Tom Lane To: Michael Paquier cc: Daniel Gustafsson , pgsql-committers@lists.postgresql.org, Andrew Dunstan Subject: Re: pgsql: Add TAP tests for contrib/sslinfo In-reply-to: References: <1632478.1638305700@sss.pgh.pa.us> <887628C4-6E1C-4DE5-BA8E-4252BA2B1A0D@yesql.se> <1636597.1638308177@sss.pgh.pa.us> <1686601.1638333261@sss.pgh.pa.us> <74D032CB-B5EE-4B39-AFBE-67F835A2CBDF@yesql.se> <50312478-6DB6-4A9A-99BF-2EACFF286149@yesql.se> <97EC3C0F-E7FB-4C5A-A15D-4E8F54CAF032@yesql.se> <1994933.1638392649@sss.pgh.pa.us> Comments: In-reply-to Michael Paquier message dated "Thu, 02 Dec 2021 07:37:49 +0900" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <2001385.1638398637.1@sss.pgh.pa.us> Date: Wed, 01 Dec 2021 17:43:57 -0500 Message-ID: <2001386.1638398637@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Michael Paquier writes: > On Wed, Dec 01, 2021 at 04:04:09PM -0500, Tom Lane wrote: >> I agree that some docs about this would be nice, but I think the rules >> for when to use perl2host are more complex than what you suggest here. >> Perhaps Andrew can clarify. > It seems to me that the rule applies to any paths passed down to the C > code of Postgres, then processed by a system call. I'm a little gun-shy of any sweeping statements here, because of bad experience (27ab1981e, b35a67bc0). It's as important to be clear about when *not* to use perl2host as when to do so. regards, tom lane