From: Bruce Momjian <bruce@momjian.us>
Message-Id: <200902071511.n17FB4t23514@momjian.us>
Subject: Re: [COMMITTERS] pgsql: Explicitly bind gettext to
	the correct encoding on Windows.
In-Reply-To: <20643.1232666867@sss.pgh.pa.us>
To: Tom Lane <tgl@sss.pgh.pa.us>
Date: Sat, 7 Feb 2009 10:11:04 -0500 (EST)
CC: Magnus Hagander <magnus@hagander.net>, pgsql-hackers@postgresql.org
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="US-ASCII"

Tom Lane wrote:
> mha@postgresql.org (Magnus Hagander) writes:
> > Explicitly bind gettext to the correct encoding on Windows.
> 
> I have a couple of objections to this patch.  First, what happens if
> it fails to find a matching table entry?  (The existing answer is
> "nothing", but that doesn't seem right.)  Second and more critical,
> it adds still another data structure that has to be maintained when
> the list of encodings changes, and it doesn't even live in the same
> file as any existing encoding-information table.
> 
> What makes more sense to me is to add a table to encnames.c that
> provides the gettext name of every encoding that we support.

Would someone please comment on Tom's questions above.

-- 
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +