pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpgsql: Remove the recently added node types ReloptElem and OptionDefElem
2+ messages / 2 participants
[nested] [flat]
* pgsql: Remove the recently added node types ReloptElem and OptionDefElem
@ 2009-04-04 21:12 Tom Lane <tgl@postgresql.org>
0 siblings, 0 replies; 2+ messages in thread
From: tgl@postgresql.org @ 2009-04-04 21:12 UTC (permalink / raw)
To: pgsql-committers
Log Message:
-----------
Remove the recently added node types ReloptElem and OptionDefElem in favor
of adding optional namespace and action fields to DefElem. Having three
node types that do essentially the same thing bloats the code and leads
to errors of confusion, such as in yesterday's bug report from Khee Chin.
Modified Files:
--------------
pgsql/src/backend/access/common:
reloptions.c (r1.25 -> r1.26)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/access/common/reloptions.c?r1=1.25&r2...)
pgsql/src/backend/commands:
define.c (r1.103 -> r1.104)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/commands/define.c?r1=1.103&r2=1.104)
foreigncmds.c (r1.6 -> r1.7)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/commands/foreigncmds.c?r1=1.6&r2=1.7)
sequence.c (r1.158 -> r1.159)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/commands/sequence.c?r1=1.158&r2=1.159)
typecmds.c (r1.132 -> r1.133)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/commands/typecmds.c?r1=1.132&r2=1.133)
view.c (r1.114 -> r1.115)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/commands/view.c?r1=1.114&r2=1.115)
pgsql/src/backend/nodes:
copyfuncs.c (r1.427 -> r1.428)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/nodes/copyfuncs.c?r1=1.427&r2=1.428)
equalfuncs.c (r1.350 -> r1.351)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/nodes/equalfuncs.c?r1=1.350&r2=1.351)
makefuncs.c (r1.63 -> r1.64)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/nodes/makefuncs.c?r1=1.63&r2=1.64)
outfuncs.c (r1.356 -> r1.357)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/nodes/outfuncs.c?r1=1.356&r2=1.357)
pgsql/src/backend/parser:
gram.y (r2.660 -> r2.661)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/parser/gram.y?r1=2.660&r2=2.661)
parse_clause.c (r1.187 -> r1.188)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/parser/parse_clause.c?r1=1.187&r2=1.1...)
pgsql/src/include/commands:
defrem.h (r1.93 -> r1.94)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/commands/defrem.h?r1=1.93&r2=1.94)
pgsql/src/include/foreign:
foreign.h (r1.3 -> r1.4)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/foreign/foreign.h?r1=1.3&r2=1.4)
pgsql/src/include/nodes:
makefuncs.h (r1.66 -> r1.67)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/nodes/makefuncs.h?r1=1.66&r2=1.67)
nodes.h (r1.221 -> r1.222)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/nodes/nodes.h?r1=1.221&r2=1.222)
parsenodes.h (r1.392 -> r1.393)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/nodes/parsenodes.h?r1=1.392&r2=1.393)
^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Merge prune, freeze and vacuum WAL record formats
@ 2024-03-25 13:01 Heikki Linnakangas <heikki.linnakangas@iki.fi>
0 siblings, 0 replies; 2+ messages in thread
From: Heikki Linnakangas @ 2024-03-25 13:01 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Merge prune, freeze and vacuum WAL record formats
The new combined WAL record is now used for pruning, freezing and 2nd
pass of vacuum. This is in preparation for changing VACUUM to write a
combined prune+freeze record per page, instead of separate two
records. The new WAL record format now supports that, but the code
still always writes separate records for pruning and freezing.
This reserves separate XLOG_HEAP2_* info codes for when the pruning
record is emitted for on-access pruning or VACUUM, per Peter
Geoghegan's suggestion. The record format is identical, but having
separate info codes makes it easier analyze pruning and vacuuming with
pg_waldump.
The function to emit the new WAL record, log_heap_prune_and_freeze(),
is in pruneheap.c. The existing heap_log_freeze_plan() and its
subroutines are moved to pruneheap.c without changes, to keep them
together with log_heap_prune_and_freeze().
Author: Melanie Plageman <melanieplageman@gmail.com>
Discussion: https://www.postgresql.org/message-id/CAAKRu_azf-zH%3DDgVbquZ3tFWjMY1w5pO8m-TXJaMdri8z3933g@mail.gma...
Discussion: https://www.postgresql.org/message-id/CAAKRu_b2oE4GL%3Dq4g9mcByS9yT7wTQvEH9OLpabj28e%2BWKFi2A@mail.g...
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/f83d709760d84253b539ee454ce9ce1ceb9ad9ac
Modified Files
--------------
src/backend/access/gist/gistxlog.c | 8 +-
src/backend/access/hash/hash_xlog.c | 9 +-
src/backend/access/heap/heapam.c | 473 ++++++++-----------------------
src/backend/access/heap/pruneheap.c | 407 ++++++++++++++++++++++----
src/backend/access/heap/vacuumlazy.c | 24 +-
src/backend/access/rmgrdesc/heapdesc.c | 230 ++++++++++-----
src/backend/replication/logical/decode.c | 6 +-
src/include/access/heapam.h | 19 +-
src/include/access/heapam_xlog.h | 220 +++++++++-----
src/include/access/xlog_internal.h | 2 +-
src/tools/pgindent/typedefs.list | 7 +-
11 files changed, 805 insertions(+), 600 deletions(-)
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2024-03-25 13:01 UTC | newest]
Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2009-04-04 21:12 pgsql: Remove the recently added node types ReloptElem and OptionDefElem Tom Lane <tgl@postgresql.org>
2024-03-25 13:01 pgsql: Merge prune, freeze and vacuum WAL record formats Heikki Linnakangas <heikki.linnakangas@iki.fi>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox