Received: from localhost (unknown [200.46.208.211]) by mail.postgresql.org (Postfix) with ESMTP id 94DC5633353 for ; Mon, 13 Apr 2009 21:06:52 -0300 (ADT) Received: from mail.postgresql.org ([200.46.204.86]) by localhost (mx1.hub.org [200.46.208.211]) (amavisd-maia, port 10024) with ESMTP id 60178-06 for ; Mon, 13 Apr 2009 21:06:37 -0300 (ADT) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from lists.commandprompt.com (host-159.commandprompt.net [207.173.203.159]) by mail.postgresql.org (Postfix) with ESMTP id 4657B63330A for ; Mon, 13 Apr 2009 21:06:43 -0300 (ADT) Received: from perhan.alvh.no-ip.org (200-126-99-132.bk7-dsl.surnet.cl [200.126.99.132]) (authenticated bits=0) by lists.commandprompt.com (8.13.8/8.13.8) with ESMTP id n3E0DmTG031134 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 13 Apr 2009 17:13:54 -0700 Received: by perhan.alvh.no-ip.org (Postfix, from userid 1000) id 974D047C79; Mon, 13 Apr 2009 20:06:34 -0400 (CLT) Date: Mon, 13 Apr 2009 20:06:34 -0400 From: Alvaro Herrera To: Tom Lane Cc: pgsql-committers@postgresql.org Subject: Re: pgsql: Make new strings more alike previously existing messages. Message-ID: <20090414000634.GM7709@alvh.no-ip.org> References: <20090413210336.300427540F4@cvs.postgresql.org> <24097.1239663420@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <24097.1239663420@sss.pgh.pa.us> User-Agent: Mutt/1.5.18 (2008-05-17) X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0 (lists.commandprompt.com [207.173.203.159]); Mon, 13 Apr 2009 17:13:55 -0700 (PDT) X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=1.063 tagged_above=0 required=5 tests=AWL=-0.630, RCVD_IN_NJABL_PROXY=1.693 X-Spam-Level: * X-Archive-Number: 200904/171 X-Sequence-Number: 36665 Tom Lane wrote: > /* Can't do single-txn mode with multiple connections */ > if (opts->single_txn && opts->number_of_jobs > 1) > { > ! fprintf(stderr, _("%s: options -1/--single-transaction and -j/--jobs cannot be used together\n"), > progname); > exit(1); > } > > As the comment and the code itself show, "-j 1" works just fine with > --single-transaction. The original wording reflected that, the new does > not. Hmm, I didn't realize that you could usefully pass -j1 ... now I realize that it even works in Make. You're right, the new message is bogus. I'll revert this part. -- Alvaro Herrera http://www.CommandPrompt.com/ PostgreSQL Replication, Consulting, Custom Development, 24x7 support