pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpginstaller - pginst: Update release process - use pg84-specific config
7+ messages / 2 participants
[nested] [flat]
* pginstaller - pginst: Update release process - use pg84-specific config
@ 2009-04-14 08:07 Dave Page <dpage@pgfoundry.org>
0 siblings, 0 replies; 7+ messages in thread
From: dpage@pgfoundry.org @ 2009-04-14 08:07 UTC (permalink / raw)
To: pgsql-committers
Log Message:
-----------
Update release process - use pg84-specific config file.
Modified Files:
--------------
pginst:
RELEASE_PROCESS.txt (r1.5 -> r1.6)
(http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/pginstaller/pginst/RELEASE_PROCESS.txt.diff?r1=1.5&r...)
^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Fix unnecessary use of moving-aggregate mode with non-moving fra
@ 2024-03-27 17:39 Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 0 replies; 7+ messages in thread
From: Tom Lane @ 2024-03-27 17:39 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix unnecessary use of moving-aggregate mode with non-moving frame.
When a plain aggregate is used as a window function, and the window
frame start is specified as UNBOUNDED PRECEDING, the frame's head
cannot move so we do not need to use moving-aggregate mode. The check
for that was put into initialize_peragg(), failing to notice that
ExecInitWindowAgg() calls that function before it's filled in
winstate->frameOptions. Since makeNode() would have zeroed the field,
this didn't provoke uninitialized-value complaints, nor would the
erroneous decision have resulted in more than a little inefficiency.
Still, it's wrong, so move the initialization of
winstate->frameOptions earlier to make it work properly.
While here, also fix a thinko in a comment. Both errors crept in in
commit a9d9acbf2 which introduced the moving-aggregate mode.
Spotted by Vallimaharajan G. Back-patch to all supported branches.
Discussion: https://postgr.es/m/18e7f2a5167.fe36253866818.977923893562469143@zohocorp.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/a767cdc84c9a4cba1f92854de55fb8b5f2de4598
Modified Files
--------------
src/backend/executor/nodeWindowAgg.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Fix unnecessary use of moving-aggregate mode with non-moving fra
@ 2024-03-27 17:39 Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 0 replies; 7+ messages in thread
From: Tom Lane @ 2024-03-27 17:39 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix unnecessary use of moving-aggregate mode with non-moving frame.
When a plain aggregate is used as a window function, and the window
frame start is specified as UNBOUNDED PRECEDING, the frame's head
cannot move so we do not need to use moving-aggregate mode. The check
for that was put into initialize_peragg(), failing to notice that
ExecInitWindowAgg() calls that function before it's filled in
winstate->frameOptions. Since makeNode() would have zeroed the field,
this didn't provoke uninitialized-value complaints, nor would the
erroneous decision have resulted in more than a little inefficiency.
Still, it's wrong, so move the initialization of
winstate->frameOptions earlier to make it work properly.
While here, also fix a thinko in a comment. Both errors crept in in
commit a9d9acbf2 which introduced the moving-aggregate mode.
Spotted by Vallimaharajan G. Back-patch to all supported branches.
Discussion: https://postgr.es/m/18e7f2a5167.fe36253866818.977923893562469143@zohocorp.com
Branch
------
REL_16_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/a94f51a7bfc9e65ce3799d8cb12945bd596c5ba8
Modified Files
--------------
src/backend/executor/nodeWindowAgg.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Fix unnecessary use of moving-aggregate mode with non-moving fra
@ 2024-03-27 17:39 Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 0 replies; 7+ messages in thread
From: Tom Lane @ 2024-03-27 17:39 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix unnecessary use of moving-aggregate mode with non-moving frame.
When a plain aggregate is used as a window function, and the window
frame start is specified as UNBOUNDED PRECEDING, the frame's head
cannot move so we do not need to use moving-aggregate mode. The check
for that was put into initialize_peragg(), failing to notice that
ExecInitWindowAgg() calls that function before it's filled in
winstate->frameOptions. Since makeNode() would have zeroed the field,
this didn't provoke uninitialized-value complaints, nor would the
erroneous decision have resulted in more than a little inefficiency.
Still, it's wrong, so move the initialization of
winstate->frameOptions earlier to make it work properly.
While here, also fix a thinko in a comment. Both errors crept in in
commit a9d9acbf2 which introduced the moving-aggregate mode.
Spotted by Vallimaharajan G. Back-patch to all supported branches.
Discussion: https://postgr.es/m/18e7f2a5167.fe36253866818.977923893562469143@zohocorp.com
Branch
------
REL_15_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/03561a6c7bbfe305b941d46f7bafb3cdd4793982
Modified Files
--------------
src/backend/executor/nodeWindowAgg.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Fix unnecessary use of moving-aggregate mode with non-moving fra
@ 2024-03-27 17:39 Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 0 replies; 7+ messages in thread
From: Tom Lane @ 2024-03-27 17:39 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix unnecessary use of moving-aggregate mode with non-moving frame.
When a plain aggregate is used as a window function, and the window
frame start is specified as UNBOUNDED PRECEDING, the frame's head
cannot move so we do not need to use moving-aggregate mode. The check
for that was put into initialize_peragg(), failing to notice that
ExecInitWindowAgg() calls that function before it's filled in
winstate->frameOptions. Since makeNode() would have zeroed the field,
this didn't provoke uninitialized-value complaints, nor would the
erroneous decision have resulted in more than a little inefficiency.
Still, it's wrong, so move the initialization of
winstate->frameOptions earlier to make it work properly.
While here, also fix a thinko in a comment. Both errors crept in in
commit a9d9acbf2 which introduced the moving-aggregate mode.
Spotted by Vallimaharajan G. Back-patch to all supported branches.
Discussion: https://postgr.es/m/18e7f2a5167.fe36253866818.977923893562469143@zohocorp.com
Branch
------
REL_14_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/0d30e48c2578a6857aa2869f1b2696b6eb5fef68
Modified Files
--------------
src/backend/executor/nodeWindowAgg.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Fix unnecessary use of moving-aggregate mode with non-moving fra
@ 2024-03-27 17:39 Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 0 replies; 7+ messages in thread
From: Tom Lane @ 2024-03-27 17:39 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix unnecessary use of moving-aggregate mode with non-moving frame.
When a plain aggregate is used as a window function, and the window
frame start is specified as UNBOUNDED PRECEDING, the frame's head
cannot move so we do not need to use moving-aggregate mode. The check
for that was put into initialize_peragg(), failing to notice that
ExecInitWindowAgg() calls that function before it's filled in
winstate->frameOptions. Since makeNode() would have zeroed the field,
this didn't provoke uninitialized-value complaints, nor would the
erroneous decision have resulted in more than a little inefficiency.
Still, it's wrong, so move the initialization of
winstate->frameOptions earlier to make it work properly.
While here, also fix a thinko in a comment. Both errors crept in in
commit a9d9acbf2 which introduced the moving-aggregate mode.
Spotted by Vallimaharajan G. Back-patch to all supported branches.
Discussion: https://postgr.es/m/18e7f2a5167.fe36253866818.977923893562469143@zohocorp.com
Branch
------
REL_13_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/de3c5b18729a234df0b9203e195a2a5c168ef1cd
Modified Files
--------------
src/backend/executor/nodeWindowAgg.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
^ permalink raw reply [nested|flat] 7+ messages in thread
* pgsql: Fix unnecessary use of moving-aggregate mode with non-moving fra
@ 2024-03-27 17:39 Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 0 replies; 7+ messages in thread
From: Tom Lane @ 2024-03-27 17:39 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix unnecessary use of moving-aggregate mode with non-moving frame.
When a plain aggregate is used as a window function, and the window
frame start is specified as UNBOUNDED PRECEDING, the frame's head
cannot move so we do not need to use moving-aggregate mode. The check
for that was put into initialize_peragg(), failing to notice that
ExecInitWindowAgg() calls that function before it's filled in
winstate->frameOptions. Since makeNode() would have zeroed the field,
this didn't provoke uninitialized-value complaints, nor would the
erroneous decision have resulted in more than a little inefficiency.
Still, it's wrong, so move the initialization of
winstate->frameOptions earlier to make it work properly.
While here, also fix a thinko in a comment. Both errors crept in in
commit a9d9acbf2 which introduced the moving-aggregate mode.
Spotted by Vallimaharajan G. Back-patch to all supported branches.
Discussion: https://postgr.es/m/18e7f2a5167.fe36253866818.977923893562469143@zohocorp.com
Branch
------
REL_12_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/25675c474292dca71470ef17ea8a53c150eb0e0a
Modified Files
--------------
src/backend/executor/nodeWindowAgg.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
^ permalink raw reply [nested|flat] 7+ messages in thread
end of thread, other threads:[~2024-03-27 17:39 UTC | newest]
Thread overview: 7+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2009-04-14 08:07 pginstaller - pginst: Update release process - use pg84-specific config Dave Page <dpage@pgfoundry.org>
2024-03-27 17:39 pgsql: Fix unnecessary use of moving-aggregate mode with non-moving fra Tom Lane <tgl@sss.pgh.pa.us>
2024-03-27 17:39 pgsql: Fix unnecessary use of moving-aggregate mode with non-moving fra Tom Lane <tgl@sss.pgh.pa.us>
2024-03-27 17:39 pgsql: Fix unnecessary use of moving-aggregate mode with non-moving fra Tom Lane <tgl@sss.pgh.pa.us>
2024-03-27 17:39 pgsql: Fix unnecessary use of moving-aggregate mode with non-moving fra Tom Lane <tgl@sss.pgh.pa.us>
2024-03-27 17:39 pgsql: Fix unnecessary use of moving-aggregate mode with non-moving fra Tom Lane <tgl@sss.pgh.pa.us>
2024-03-27 17:39 pgsql: Fix unnecessary use of moving-aggregate mode with non-moving fra Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox