pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Substitute extraneous underscores with spaces.
4+ messages / 4 participants
[nested] [flat]

* pgsql: Substitute extraneous underscores with spaces.
@ 2009-04-15 23:30 Alvaro Herrera <alvherre@postgresql.org>
  2009-04-16 12:58 ` Re: pgsql: Substitute extraneous underscores with spaces. Andrew Dunstan <andrew@dunslane.net>
  0 siblings, 1 reply; 4+ messages in thread

From: alvherre@postgresql.org @ 2009-04-15 23:30 UTC (permalink / raw)
  To: pgsql-committers

Log Message:
-----------
Substitute extraneous underscores with spaces.

Modified Files:
--------------
    pgsql/src/backend/utils/adt:
        arrayfuncs.c (r1.155 -> r1.156)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/adt/arrayfuncs.c?r1=1.155&r2=1....)



^ permalink  raw  reply  [nested|flat] 4+ messages in thread

* Re: pgsql: Substitute extraneous underscores with spaces.
  2009-04-15 23:30 pgsql: Substitute extraneous underscores with spaces. Alvaro Herrera <alvherre@postgresql.org>
@ 2009-04-16 12:58 ` Andrew Dunstan <andrew@dunslane.net>
  2009-04-16 14:37   ` Re: pgsql: Substitute extraneous underscores with spaces. Alvaro Herrera <alvherre@commandprompt.com>
  0 siblings, 1 reply; 4+ messages in thread

From: Andrew Dunstan @ 2009-04-16 12:58 UTC (permalink / raw)
  To: Alvaro Herrera <alvherre@postgresql.org>; +Cc: pgsql-committers



Alvaro Herrera wrote:
> Log Message:
> -----------
> Substitute extraneous underscores with spaces.
>
> Modified Files:
> --------------
>     pgsql/src/backend/utils/adt:
>         arrayfuncs.c (r1.155 -> r1.156)
>         (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/adt/arrayfuncs.c?r1=1.155&r2=1....)
>   


This has broken the regression tests and sent the buildfarm red.

cheers

andrew



^ permalink  raw  reply  [nested|flat] 4+ messages in thread

* Re: pgsql: Substitute extraneous underscores with spaces.
  2009-04-15 23:30 pgsql: Substitute extraneous underscores with spaces. Alvaro Herrera <alvherre@postgresql.org>
  2009-04-16 12:58 ` Re: pgsql: Substitute extraneous underscores with spaces. Andrew Dunstan <andrew@dunslane.net>
@ 2009-04-16 14:37   ` Alvaro Herrera <alvherre@commandprompt.com>
  0 siblings, 0 replies; 4+ messages in thread

From: Alvaro Herrera @ 2009-04-16 14:37 UTC (permalink / raw)
  To: Andrew Dunstan <andrew@dunslane.net>; +Cc: pgsql-committers

Andrew Dunstan wrote:
> Alvaro Herrera wrote:
>> Log Message:
>> -----------
>> Substitute extraneous underscores with spaces.
>>
>> Modified Files:
>> --------------
>>     pgsql/src/backend/utils/adt:
>>         arrayfuncs.c (r1.155 -> r1.156)
>>         (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/adt/arrayfuncs.c?r1=1.155&r2=1....)
>
> This has broken the regression tests and sent the buildfarm red.

Argh ...

I'm on it.  Thanks for the note.

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support




^ permalink  raw  reply  [nested|flat] 4+ messages in thread

* pgsql: Try to stabilize flappy test result.
@ 2024-03-29 14:40 Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 4+ messages in thread

From: Tom Lane @ 2024-03-29 14:40 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Try to stabilize flappy test result.

This recently-added test case checks the plan of an inner join
between two identical tables.  It's just chance which join order
the planner will pick, and in the presence of any variation in
the underlying statistics, the displayed plan might change.
Add a WHERE condition to break the cost symmetry and hopefully
stabilize matters.

(We're still trying to understand exactly why the underlying
statistics aren't as stable as intended, but this seems like
a good change anyway, since this test would surely bite us
again in future.)

While here, clean up assorted comment spelling, grammar, and
whitespace problems.

Discussion: https://postgr.es/m/4168116.1711720146@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/c2df2ed90a82fc0acd07ed88ac433350edfd6b54

Modified Files
--------------
src/test/regress/expected/subselect.out | 14 ++++++++------
src/test/regress/sql/subselect.sql      | 13 +++++++------
2 files changed, 15 insertions(+), 12 deletions(-)



^ permalink  raw  reply  [nested|flat] 4+ messages in thread


end of thread, other threads:[~2024-03-29 14:40 UTC | newest]

Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2009-04-15 23:30 pgsql: Substitute extraneous underscores with spaces. Alvaro Herrera <alvherre@postgresql.org>
2009-04-16 12:58 ` Andrew Dunstan <andrew@dunslane.net>
2009-04-16 14:37   ` Alvaro Herrera <alvherre@commandprompt.com>
2024-03-29 14:40 pgsql: Try to stabilize flappy test result. Tom Lane <tgl@sss.pgh.pa.us>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox