pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
autodoc - autodoc: Add -m <regex> to only output structures or functions
2+ messages / 2 participants
[nested] [flat]

* autodoc - autodoc: Add -m <regex> to only output structures or functions
@ 2009-04-24 04:41 User Rbt <rbt@pgfoundry.org>
  0 siblings, 0 replies; 2+ messages in thread

From: rbt@pgfoundry.org @ 2009-04-24 04:41 UTC (permalink / raw)
  To: pgsql-committers

Log Message:
-----------
Add -m <regex> to only output structures or functions matching a specific regex (Simon Michael)

Tidy code along the way.

Modified Files:
--------------
    autodoc:
        postgresql_autodoc.pl (r1.23 -> r1.24)
        (http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/autodoc/autodoc/postgresql_autodoc.pl.diff?r1=1.23&r...)




^ permalink  raw  reply  [nested|flat] 2+ messages in thread

* pgsql: Fix bug in bulk extending temp relation after failure
@ 2024-02-02 19:32 Heikki Linnakangas <heikki.linnakangas@iki.fi>
  0 siblings, 0 replies; 2+ messages in thread

From: Heikki Linnakangas @ 2024-02-02 19:32 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Fix bug in bulk extending temp relation after failure

A ResourceOwnerEnlarge() call was missing. That led to an error:

ERROR:  ResourceOwnerRemember called but array was full

and an assertion failure, if you tried to extend a temp relation again
after a failure. Alexander's test case used running out of disk space
to trigger the original failure.

This bug was introduced in the large ResourceOwner rewrite commit
b8bff07daa. Before that, the UnpinLocalBuffer() call guaranteed that
the subsequent PinLocalBuffer() will succeed, but after the rewrite,
releasing an old resource doesn't guarantee that there is space for a
new one.

Add a comment explaining why the UnpinBuffer + PinBuffer calls in
BufferAlloc(), with no ResourceOwnerEnlarge() in between, are safe.

Reported-by: Alexander Lakhin
Discussion: https://www.postgresql.org/message-id/dc574fea-c83e-a600-08cd-10881762e4fa@gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/d212957254de85aad934e2601e5a07661db268fb

Modified Files
--------------
src/backend/storage/buffer/localbuf.c | 5 +++++
src/backend/utils/resowner/resowner.c | 7 ++++++-
2 files changed, 11 insertions(+), 1 deletion(-)



^ permalink  raw  reply  [nested|flat] 2+ messages in thread


end of thread, other threads:[~2024-02-02 19:32 UTC | newest]

Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2009-04-24 04:41 autodoc - autodoc: Add -m <regex> to only output structures or functions User Rbt <rbt@pgfoundry.org>
2024-02-02 19:32 pgsql: Fix bug in bulk extending temp relation after failure Heikki Linnakangas <heikki.linnakangas@iki.fi>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox