pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpg-migrator - pg_migrator: Stamp alpha 17.
4+ messages / 2 participants
[nested] [flat]
* pg-migrator - pg_migrator: Stamp alpha 17.
@ 2009-06-03 16:03 User Bmomjian <bmomjian@pgfoundry.org>
0 siblings, 0 replies; 4+ messages in thread
From: bmomjian@pgfoundry.org @ 2009-06-03 16:03 UTC (permalink / raw)
To: pgsql-committers
Log Message:
-----------
Stamp alpha 17.
Modified Files:
--------------
pg_migrator/src:
pg_migrator.h (r1.44 -> r1.45)
(http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/pg-migrator/pg_migrator/src/pg_migrator.h?r1=1.44&r2...)
^ permalink raw reply [nested|flat] 4+ messages in thread
* pg-migrator - pg_migrator: Stamp alpha 17.
@ 2009-06-03 16:04 User Bmomjian <bmomjian@pgfoundry.org>
0 siblings, 0 replies; 4+ messages in thread
From: bmomjian@pgfoundry.org @ 2009-06-03 16:04 UTC (permalink / raw)
To: pgsql-committers
Log Message:
-----------
Stamp alpha 17.
Modified Files:
--------------
pg_migrator:
README (r1.27 -> r1.28)
(http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/pg-migrator/pg_migrator/README?r1=1.27&r2=1.28)
^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: Ensure generated join clauses for child rels have correct relids
@ 2024-04-16 15:23 Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 0 replies; 4+ messages in thread
From: Tom Lane @ 2024-04-16 15:23 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Ensure generated join clauses for child rels have correct relids.
When building a join clause derived from an EquivalenceClass, if the
clause is to be used with an appendrel child relation then make sure
its clause_relids include the relids of that child relation.
Normally this would be true already because the EquivalenceMember
would be a Var of that relation. However, if the appendrel represents
a flattened UNION ALL construct then some child EquivalenceMembers
could be constants with no relids. The resulting under-marked clause
is problematic because it could mislead join_clause_is_movable_into
about where the clause should be evaluated. We do not have an example
showing incorrect plan generation, but there are existing cases in
the regression tests that will fail the Asserts this patch adds to
get_baserel_parampathinfo. A similarly wrong conclusion about a
clause being considered by get_joinrel_parampathinfo would lead to
wrong placement of the clause. (This also squares with the way
that clause_relids is calculated for non-equijoin clauses in
adjust_appendrel_attrs.)
The other reason for wanting these new Asserts is that the previous
blithe assumption that the results of generate_join_implied_equalities
"necessarily satisfy join_clause_is_movable_into" turns out to be
wrong pre-v16. If it's still wrong it'd be good to find out.
Per bug #18429 from Benoît Ryder. The bug as filed was fixed by
commit 2489d76c4, but these changes correlate with the fix we
will need to apply in pre-v16 branches.
Discussion: https://postgr.es/m/18429-8982d4a348cc86c6@postgresql.org
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/03107b4eda7f2946bb78308cb088a513b718c793
Modified Files
--------------
src/backend/optimizer/path/equivclass.c | 15 +++++++++++++++
src/backend/optimizer/util/relnode.c | 26 +++++++++++++++++++-------
2 files changed, 34 insertions(+), 7 deletions(-)
^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: Ensure generated join clauses for child rels have correct relids
@ 2024-04-16 15:23 Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 0 replies; 4+ messages in thread
From: Tom Lane @ 2024-04-16 15:23 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Ensure generated join clauses for child rels have correct relids.
When building a join clause derived from an EquivalenceClass, if the
clause is to be used with an appendrel child relation then make sure
its clause_relids include the relids of that child relation.
Normally this would be true already because the EquivalenceMember
would be a Var of that relation. However, if the appendrel represents
a flattened UNION ALL construct then some child EquivalenceMembers
could be constants with no relids. The resulting under-marked clause
is problematic because it could mislead join_clause_is_movable_into
about where the clause should be evaluated. We do not have an example
showing incorrect plan generation, but there are existing cases in
the regression tests that will fail the Asserts this patch adds to
get_baserel_parampathinfo. A similarly wrong conclusion about a
clause being considered by get_joinrel_parampathinfo would lead to
wrong placement of the clause. (This also squares with the way
that clause_relids is calculated for non-equijoin clauses in
adjust_appendrel_attrs.)
The other reason for wanting these new Asserts is that the previous
blithe assumption that the results of generate_join_implied_equalities
"necessarily satisfy join_clause_is_movable_into" turns out to be
wrong pre-v16. If it's still wrong it'd be good to find out.
Per bug #18429 from Benoît Ryder. The bug as filed was fixed by
commit 2489d76c4, but these changes correlate with the fix we
will need to apply in pre-v16 branches.
Discussion: https://postgr.es/m/18429-8982d4a348cc86c6@postgresql.org
Branch
------
REL_16_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/91800af1371029f75e8e34d55e9b412706eec182
Modified Files
--------------
src/backend/optimizer/path/equivclass.c | 15 +++++++++++++++
src/backend/optimizer/util/relnode.c | 26 +++++++++++++++++++-------
2 files changed, 34 insertions(+), 7 deletions(-)
^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2024-04-16 15:23 UTC | newest]
Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2009-06-03 16:03 pg-migrator - pg_migrator: Stamp alpha 17. User Bmomjian <bmomjian@pgfoundry.org>
2009-06-03 16:04 pg-migrator - pg_migrator: Stamp alpha 17. User Bmomjian <bmomjian@pgfoundry.org>
2024-04-16 15:23 pgsql: Ensure generated join clauses for child rels have correct relids Tom Lane <tgl@sss.pgh.pa.us>
2024-04-16 15:23 pgsql: Ensure generated join clauses for child rels have correct relids Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox