pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpgsql: Fix a serious bug introduced into GIN in 8.4: now that
2+ messages / 2 participants
[nested] [flat]
* pgsql: Fix a serious bug introduced into GIN in 8.4: now that
@ 2009-06-06 02:39 Tom Lane <tgl@postgresql.org>
0 siblings, 0 replies; 2+ messages in thread
From: tgl@postgresql.org @ 2009-06-06 02:39 UTC (permalink / raw)
To: pgsql-committers
Log Message:
-----------
Fix a serious bug introduced into GIN in 8.4: now that MergeItemPointers()
is supposed to remove duplicate heap TIDs, we have to be sure to reduce the
tuple size and posting-item count accordingly in addItemPointersToTuple().
Failing to do so resulted in the effective injection of garbage TIDs into the
index contents, ie, whatever happened to be in the memory palloc'd for the
new tuple. I'm not sure that this fully explains the index corruption
reported by Tatsuo Ishii, but the test case I'm using no longer fails.
Modified Files:
--------------
pgsql/src/backend/access/gin:
gindatapage.c (r1.14 -> r1.15)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/access/gin/gindatapage.c?r1=1.14&r2=1...)
ginentrypage.c (r1.19 -> r1.20)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/access/gin/ginentrypage.c?r1=1.19&r2=...)
gininsert.c (r1.20 -> r1.21)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/access/gin/gininsert.c?r1=1.20&r2=1.2...)
pgsql/src/include/access:
gin.h (r1.32 -> r1.33)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/access/gin.h?r1=1.32&r2=1.33)
^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Fix typos and duplicate words
@ 2024-04-18 19:30 Daniel Gustafsson <dgustafsson@postgresql.org>
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Gustafsson @ 2024-04-18 19:30 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Fix typos and duplicate words
This fixes various typos, duplicated words, and tiny bits of whitespace
mainly in code comments but also in docs.
Author: Daniel Gustafsson <daniel@yesql.se>
Author: Heikki Linnakangas <hlinnaka@iki.fi>
Author: Alexander Lakhin <exclusion@gmail.com>
Author: David Rowley <dgrowleyml@gmail.com>
Author: Nazir Bilal Yavuz <byavuz81@gmail.com>
Discussion: https://postgr.es/m/3F577953-A29E-4722-98AD-2DA9EFF2CBB8@yesql.se
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/950d4a2cb1d5f427dbccf70dbad510479cc4d8e6
Modified Files
--------------
contrib/amcheck/expected/check_btree.out | 2 +-
contrib/amcheck/sql/check_btree.sql | 2 +-
contrib/amcheck/verify_nbtree.c | 2 +-
doc/src/sgml/maintenance.sgml | 2 +-
doc/src/sgml/meson.build | 2 +-
src/backend/access/gin/ginbtree.c | 2 +-
src/backend/access/heap/pruneheap.c | 6 +++---
src/backend/access/nbtree/nbtutils.c | 4 ++--
src/backend/access/rmgrdesc/xactdesc.c | 2 +-
src/backend/catalog/pg_constraint.c | 2 +-
src/backend/catalog/system_functions.sql | 2 +-
src/backend/commands/amcmds.c | 2 +-
src/backend/commands/copyfrom.c | 2 +-
src/backend/commands/dbcommands.c | 4 ++--
src/backend/commands/tablecmds.c | 2 +-
src/backend/commands/vacuumparallel.c | 2 +-
src/backend/executor/execExpr.c | 2 +-
src/backend/optimizer/path/equivclass.c | 2 +-
src/backend/optimizer/path/pathkeys.c | 2 +-
src/backend/optimizer/prep/prepunion.c | 3 ++-
src/backend/parser/parse_jsontable.c | 2 +-
src/backend/parser/parse_utilcmd.c | 4 ++--
src/backend/partitioning/partbounds.c | 6 +++---
src/backend/partitioning/partprune.c | 2 +-
src/backend/postmaster/launch_backend.c | 2 +-
src/backend/postmaster/walsummarizer.c | 2 +-
src/backend/replication/logical/slotsync.c | 2 +-
src/backend/replication/walsender.c | 2 +-
src/backend/statistics/dependencies.c | 4 ++--
src/backend/storage/aio/read_stream.c | 6 +++---
src/backend/storage/buffer/bufmgr.c | 2 +-
src/backend/storage/lmgr/lock.c | 2 +-
src/backend/storage/lmgr/proc.c | 2 +-
src/backend/utils/adt/jsonpath_exec.c | 4 ++--
src/backend/utils/adt/multirangetypes.c | 2 +-
src/backend/utils/adt/selfuncs.c | 2 +-
src/backend/utils/mmgr/aset.c | 4 ++--
src/backend/utils/mmgr/bump.c | 4 ++--
src/backend/utils/mmgr/generation.c | 4 ++--
src/bin/pg_basebackup/bbstreamer_tar.c | 2 +-
src/bin/pg_combinebackup/pg_combinebackup.c | 2 +-
src/bin/pg_combinebackup/reconstruct.c | 2 +-
src/bin/pg_upgrade/t/004_subscription.pl | 2 +-
src/common/unicode_category.c | 2 +-
src/include/access/heapam_xlog.h | 10 +++++-----
src/include/common/hashfn_unstable.h | 2 +-
src/include/lib/radixtree.h | 6 +++---
src/include/nodes/pathnodes.h | 2 +-
src/include/nodes/primnodes.h | 2 +-
src/include/storage/proc.h | 2 +-
src/interfaces/libpq/fe-cancel.c | 2 +-
src/interfaces/libpq/fe-secure-openssl.c | 2 +-
src/test/isolation/expected/temp-schema-cleanup.out | 4 ++--
src/test/isolation/specs/temp-schema-cleanup.spec | 2 +-
src/test/modules/test_resowner/test_resowner_many.c | 2 +-
src/test/regress/expected/aggregates.out | 2 +-
src/test/regress/expected/copy.out | 4 ++--
src/test/regress/expected/foreign_key.out | 2 +-
src/test/regress/expected/publication.out | 4 ++--
src/test/regress/expected/tsdicts.out | 2 +-
src/test/regress/sql/aggregates.sql | 2 +-
src/test/regress/sql/copy.sql | 4 ++--
src/test/regress/sql/foreign_key.sql | 2 +-
src/test/regress/sql/publication.sql | 4 ++--
src/test/regress/sql/tsdicts.sql | 2 +-
src/test/subscription/t/004_sync.pl | 2 +-
src/test/subscription/t/026_stats.pl | 2 +-
67 files changed, 93 insertions(+), 92 deletions(-)
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2024-04-18 19:30 UTC | newest]
Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2009-06-06 02:39 pgsql: Fix a serious bug introduced into GIN in 8.4: now that Tom Lane <tgl@postgresql.org>
2024-04-18 19:30 pgsql: Fix typos and duplicate words Daniel Gustafsson <dgustafsson@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox