pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpgsql: Restore dblink_current_query() to being a C-language function, so
4+ messages / 2 participants
[nested] [flat]
* pgsql: Restore dblink_current_query() to being a C-language function, so
@ 2009-06-09 17:41 Tom Lane <tgl@postgresql.org>
0 siblings, 0 replies; 4+ messages in thread
From: tgl@postgresql.org @ 2009-06-09 17:41 UTC (permalink / raw)
To: pgsql-committers
Log Message:
-----------
Restore dblink_current_query() to being a C-language function, so as to not
create an ABI break between 8.3 and 8.4. It is still just a wrapper around
the built-in current_query() function, but at a different implementation
level. Per my proposal.
Note: this change doesn't break 8.4beta installations, since their
SQL-language definition of the function still works fine.
Modified Files:
--------------
pgsql/contrib/dblink:
dblink.c (r1.80 -> r1.81)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/contrib/dblink/dblink.c?r1=1.80&r2=1.81)
dblink.h (r1.21 -> r1.22)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/contrib/dblink/dblink.h?r1=1.21&r2=1.22)
dblink.sql.in (r1.17 -> r1.18)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/contrib/dblink/dblink.sql.in?r1=1.17&r2=1.18)
^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: createdb: compare strategy case-insensitive
@ 2024-04-21 19:31 Tomas Vondra <tomas.vondra@postgresql.org>
0 siblings, 0 replies; 4+ messages in thread
From: Tomas Vondra @ 2024-04-21 19:31 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
createdb: compare strategy case-insensitive
When specifying the createdb strategy, the documentation suggests valid
options are FILE_COPY and WAL_LOG, but the code does case-sensitive
comparison and accepts only "file_copy" and "wal_log" as valid.
Fixed by doing a case-insensitive comparison using pg_strcasecmp(), same
as for other string parameters nearby.
While at it, apply fmtId() to a nearby "locale_provider". This already
did the comparison in case-insensitive way, but the value would not be
double-quoted, confusing the parser and the error message.
Backpatch to 15, where the strategy was introduced.
Backpatch-through: 15
Reviewed-by: Tom Lane
Discussion: https://postgr.es/m/90c6913a-1dd2-42b4-8365-ce3b09c39b17@enterprisedb.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/8c239ee15a4b093523ebe30bdc9af186aaccebfd
Modified Files
--------------
src/backend/commands/dbcommands.c | 6 +++---
src/bin/scripts/createdb.c | 2 +-
src/bin/scripts/t/020_createdb.pl | 10 ++++++++++
3 files changed, 14 insertions(+), 4 deletions(-)
^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: createdb: compare strategy case-insensitive
@ 2024-04-21 19:31 Tomas Vondra <tomas.vondra@postgresql.org>
0 siblings, 0 replies; 4+ messages in thread
From: Tomas Vondra @ 2024-04-21 19:31 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
createdb: compare strategy case-insensitive
When specifying the createdb strategy, the documentation suggests valid
options are FILE_COPY and WAL_LOG, but the code does case-sensitive
comparison and accepts only "file_copy" and "wal_log" as valid.
Fixed by doing a case-insensitive comparison using pg_strcasecmp(), same
as for other string parameters nearby.
While at it, apply fmtId() to a nearby "locale_provider". This already
did the comparison in case-insensitive way, but the value would not be
double-quoted, confusing the parser and the error message.
Backpatch to 15, where the strategy was introduced.
Backpatch-through: 15
Reviewed-by: Tom Lane
Discussion: https://postgr.es/m/90c6913a-1dd2-42b4-8365-ce3b09c39b17@enterprisedb.com
Branch
------
REL_16_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/9e6faeb3249d420a22ad8a5fbcf093b272c02cb8
Modified Files
--------------
src/backend/commands/dbcommands.c | 6 +++---
src/bin/scripts/createdb.c | 2 +-
src/bin/scripts/t/020_createdb.pl | 10 ++++++++++
3 files changed, 14 insertions(+), 4 deletions(-)
^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: createdb: compare strategy case-insensitive
@ 2024-04-21 19:31 Tomas Vondra <tomas.vondra@postgresql.org>
0 siblings, 0 replies; 4+ messages in thread
From: Tomas Vondra @ 2024-04-21 19:31 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
createdb: compare strategy case-insensitive
When specifying the createdb strategy, the documentation suggests valid
options are FILE_COPY and WAL_LOG, but the code does case-sensitive
comparison and accepts only "file_copy" and "wal_log" as valid.
Fixed by doing a case-insensitive comparison using pg_strcasecmp(), same
as for other string parameters nearby.
While at it, apply fmtId() to a nearby "locale_provider". This already
did the comparison in case-insensitive way, but the value would not be
double-quoted, confusing the parser and the error message.
Backpatch to 15, where the strategy was introduced.
Backpatch-through: 15
Reviewed-by: Tom Lane
Discussion: https://postgr.es/m/90c6913a-1dd2-42b4-8365-ce3b09c39b17@enterprisedb.com
Branch
------
REL_15_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/276b7888f161bb149217a55008d7f7c17126f9a4
Modified Files
--------------
src/backend/commands/dbcommands.c | 6 +++---
src/bin/scripts/createdb.c | 2 +-
src/bin/scripts/t/020_createdb.pl | 10 ++++++++++
3 files changed, 14 insertions(+), 4 deletions(-)
^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2024-04-21 19:31 UTC | newest]
Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2009-06-09 17:41 pgsql: Restore dblink_current_query() to being a C-language function, so Tom Lane <tgl@postgresql.org>
2024-04-21 19:31 pgsql: createdb: compare strategy case-insensitive Tomas Vondra <tomas.vondra@postgresql.org>
2024-04-21 19:31 pgsql: createdb: compare strategy case-insensitive Tomas Vondra <tomas.vondra@postgresql.org>
2024-04-21 19:31 pgsql: createdb: compare strategy case-insensitive Tomas Vondra <tomas.vondra@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox