Received: from localhost (unknown [200.46.208.211]) by mail.postgresql.org (Postfix) with ESMTP id 9D76F635642 for ; Wed, 10 Jun 2009 00:45:01 -0300 (ADT) Received: from mail.postgresql.org ([200.46.204.86]) by localhost (mx1.hub.org [200.46.208.211]) (amavisd-maia, port 10024) with ESMTP id 81220-09 for ; Wed, 10 Jun 2009 00:44:50 -0300 (ADT) Received: from cvs.postgresql.org (cvs.postgresql.org [217.196.146.206]) by mail.postgresql.org (Postfix) with ESMTP id 0FCD9635449 for ; Wed, 10 Jun 2009 00:44:46 -0300 (ADT) Received: by cvs.postgresql.org (Postfix, from userid 1007) id 1C02375331E; Wed, 10 Jun 2009 03:44:35 +0000 (UTC) MIME-Version: 1.0 To: pgsql-committers@postgresql.org Subject: pgsql: Ensure xmlFree(NULL) is a no-op instead of a core dump. X-Mailer: activitymail 1.24, http://search.cpan.org/dist/activitymail/ Content-Type: text/plain Message-Id: <20090610034435.1C02375331E@cvs.postgresql.org> Date: Wed, 10 Jun 2009 03:44:35 +0000 (UTC) From: tgl@postgresql.org (Tom Lane) X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=0 tagged_above=0 required=5 tests=none X-Spam-Level: X-Archive-Number: 200906/142 X-Sequence-Number: 37346 Log Message: ----------- Ensure xmlFree(NULL) is a no-op instead of a core dump. Per report from Sergey Burladyan, there are at least some dank corners of libxml2 that assume this behavior, even though their published documentation suggests they shouldn't. This is only really a live problem in 8.3, but the code is still there for possible debugging use in HEAD, so patch both branches. Modified Files: -------------- pgsql/src/backend/utils/adt: xml.c (r1.90 -> r1.91) (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/adt/xml.c?r1=1.90&r2=1.91)