pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpgsql: Fix get_sort_group_operators() so that it doesn't think arrays
2+ messages / 2 participants
[nested] [flat]
* pgsql: Fix get_sort_group_operators() so that it doesn't think arrays
@ 2009-06-13 15:42 Tom Lane <tgl@postgresql.org>
0 siblings, 0 replies; 2+ messages in thread
From: tgl@postgresql.org @ 2009-06-13 15:42 UTC (permalink / raw)
To: pgsql-committers
Log Message:
-----------
Fix get_sort_group_operators() so that it doesn't think arrays can be grouped
via hashing. Eventually we ought to make that possible, but it won't happen
for 8.4. Per yesterday's report from Robert Haas.
Modified Files:
--------------
pgsql/src/backend/parser:
parse_oper.c (r1.108 -> r1.109)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/parser/parse_oper.c?r1=1.108&r2=1.109)
^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Make two-phase tests of ECPG and main suite more concurrent-proo
@ 2024-04-29 12:12 Michael Paquier <michael@paquier.xyz>
0 siblings, 0 replies; 2+ messages in thread
From: Michael Paquier @ 2024-04-29 12:12 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Make two-phase tests of ECPG and main suite more concurrent-proof
The ECPG and main 2PC tests have been using rather-generic names for the
prepared transactions they generate. This commit switches the 2PC
transactions to use more complex GIDs, reducing the risk of naming
conflicts.
The main 2PC tests also include scans of pg_prepared_xacts that do not
apply filters on the GID of the prepared transactions, making it
possible to fail the test when any 2PC transaction runs concurrently.
The CI has been able to see such failures with an installcheck
running the ECPG and the main regression test suites in parallel. The
queries on pg_prepared_xacts gain quals to only look after the GIDs
generated locally.
The race is very hard to reproduce, so no backbatch is done for now.
Reported-by: Richard Guo
Discussion: https://postgr.es/m/CAMbWs4-mWCGbbE_bne5=AfqjYGDaUZmjCw2+soLjrdNA0xUDFw@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/7e61e4cc7cfcf2a34f063094aeab01fdba7b65f6
Modified Files
--------------
src/interfaces/ecpg/test/expected/sql-twophase.c | 4 +-
.../ecpg/test/expected/sql-twophase.stderr | 4 +-
src/interfaces/ecpg/test/sql/twophase.pgc | 4 +-
src/test/regress/expected/prepared_xacts.out | 98 +++++++++++-----------
src/test/regress/expected/prepared_xacts_1.out | 62 +++++++-------
src/test/regress/sql/prepared_xacts.sql | 50 +++++------
6 files changed, 111 insertions(+), 111 deletions(-)
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2024-04-29 12:12 UTC | newest]
Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2009-06-13 15:42 pgsql: Fix get_sort_group_operators() so that it doesn't think arrays Tom Lane <tgl@postgresql.org>
2024-04-29 12:12 pgsql: Make two-phase tests of ECPG and main suite more concurrent-proo Michael Paquier <michael@paquier.xyz>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox