pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedprefix - prefix: Fix pr_cmp() and have pr_lt() and pr_gt() use it rather
2+ messages / 2 participants
[nested] [flat]
* prefix - prefix: Fix pr_cmp() and have pr_lt() and pr_gt() use it rather
@ 2009-06-14 23:13 User Dim <dim@pgfoundry.org>
0 siblings, 0 replies; 2+ messages in thread
From: dim@pgfoundry.org @ 2009-06-14 23:13 UTC (permalink / raw)
To: pgsql-committers
Log Message:
-----------
Fix pr_cmp() and have pr_lt() and pr_gt() use it rather than the other way round
Modified Files:
--------------
prefix:
README.txt (r1.13 -> r1.14)
(http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/prefix/prefix/README.txt?r1=1.13&r2=1.14)
prefix.c (r1.50 -> r1.51)
(http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/prefix/prefix/prefix.c?r1=1.50&r2=1.51)
Added Files:
-----------
prefix:
queries.sql (r1.1)
(http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/prefix/prefix/queries.sql?rev=1.1&content-type=text/...)
^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Avoid repeating loads of frozen ID values.
@ 2024-04-29 17:30 Noah Misch <noah@leadboat.com>
0 siblings, 0 replies; 2+ messages in thread
From: Noah Misch @ 2024-04-29 17:30 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Avoid repeating loads of frozen ID values.
Repeating loads of inplace-updated fields tends to cause bugs like the
one from the previous commit. While there's no bug to fix in these code
sites, adopt the load-once style. This improves the chance of future
copy/paste finding the safe style.
Discussion: https://postgr.es/m/20240423003956.e7.nmisch@google.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/dd0183469bb779247c96e86c2272dca7ff4ec9e7
Modified Files
--------------
src/backend/access/heap/heapam.c | 16 ++++++++++------
src/backend/commands/cluster.c | 22 ++++++++++++++--------
src/backend/commands/vacuum.c | 4 ++--
src/backend/postmaster/autovacuum.c | 13 ++++++++-----
4 files changed, 34 insertions(+), 21 deletions(-)
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2024-04-29 17:30 UTC | newest]
Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2009-06-14 23:13 prefix - prefix: Fix pr_cmp() and have pr_lt() and pr_gt() use it rather User Dim <dim@pgfoundry.org>
2024-04-29 17:30 pgsql: Avoid repeating loads of frozen ID values. Noah Misch <noah@leadboat.com>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox