pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpgsql: Fix a few errors in comments.
2+ messages / 2 participants
[nested] [flat]
* pgsql: Fix a few errors in comments.
@ 2009-06-18 10:08 Heikki Linnakangas <heikki@postgresql.org>
0 siblings, 0 replies; 2+ messages in thread
From: heikki@postgresql.org @ 2009-06-18 10:08 UTC (permalink / raw)
To: pgsql-committers
Log Message:
-----------
Fix a few errors in comments. Patch by Fujii Masao, plus the one in
visibilitymap.c by me.
Modified Files:
--------------
pgsql/contrib/pg_standby:
pg_standby.c (r1.23 -> r1.24)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/contrib/pg_standby/pg_standby.c?r1=1.23&r2=1.24)
pgsql/src/backend/access/heap:
visibilitymap.c (r1.4 -> r1.5)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/access/heap/visibilitymap.c?r1=1.4&r2...)
pgsql/src/backend/tcop:
postgres.c (r1.567 -> r1.568)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/tcop/postgres.c?r1=1.567&r2=1.568)
^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Change the way ATExecMergePartitions() handles the name collisio
@ 2024-04-30 09:00 Alexander Korotkov <akorotkov@postgresql.org>
0 siblings, 0 replies; 2+ messages in thread
From: Alexander Korotkov @ 2024-04-30 09:00 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Change the way ATExecMergePartitions() handles the name collision
The name collision happens when the name of the new partition is the same as
the name of one of the merging partitions. Currently, ATExecMergePartitions()
first gives the new partition a temporary name and then renames it when old
partitions are deleted. That negatively influences the naming of related
objects like indexes and constrains, which could inherit a temporary name.
This commit changes the implementation in the following way. A merging
partition gets renamed first, then the new partition is created with the
right name immediately. This resolves the issue of the naming of related
objects.
Reported-by: Alexander Lakhin
Discussion: https://postgr.es/m/edfbd846-dcc1-42d1-ac26-715691b687d3%40postgrespro.ru
Author: Dmitry Koval, Alexander Korotkov
Reviewed-by: Robert Haas, Justin Pryzby, Pavel Borisov
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/885742b9f88b9386368ee94df8c94d154677ffba
Modified Files
--------------
src/backend/commands/tablecmds.c | 63 +++++++++++++--------------
src/test/regress/expected/partition_merge.out | 25 +++++++++++
src/test/regress/sql/partition_merge.sql | 18 ++++++++
3 files changed, 73 insertions(+), 33 deletions(-)
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2024-04-30 09:00 UTC | newest]
Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2009-06-18 10:08 pgsql: Fix a few errors in comments. Heikki Linnakangas <heikki@postgresql.org>
2024-04-30 09:00 pgsql: Change the way ATExecMergePartitions() handles the name collisio Alexander Korotkov <akorotkov@postgresql.org>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox